Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-10 Thread Laszlo Ersek
On 12/10/13 06:51, Yao, Jiewen wrote: > I am not sure how you did it for Ovmf. > In general, we use below way for real platform, for your information only. > > 1) In code boot, a DXE phase platform driver allocates OS-Reserved Memory > type (EfiReservedType, or EfiAcpiNvs) for S3 PeiCore usage du

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Yao, Jiewen
[mailto:ler...@redhat.com] Sent: Tuesday, December 10, 2013 1:38 PM To: Yao, Jiewen Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE On 12/10/13 06:27, Yao, Jiewen wrote: > If Ovmf "preallocate ev

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Laszlo Ersek
On 12/10/13 06:27, Yao, Jiewen wrote: > If Ovmf "preallocate everything necessary in runtime services data > *or* acpi NVS type areas for the S3 resume path", the all S3 > AllocatePool or AllocatePages *should* be in those memory. > > Would you please investigate why you cannot get memory reserved

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Laszlo Ersek
On 12/10/13 05:59, Yao, Jiewen wrote: > Clarify myself. I have question on the sentence below: > "In that case the new allocation will fall outside of the permanent > RAM area that may have been reserved from the OS, for example as ACPI > NVS memory." > > 1) ACPI Nvs is reserved from OS. BIOS *CAN

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Yao, Jiewen
mailto:ler...@redhat.com] Sent: Tuesday, December 10, 2013 1:14 PM To: Yao, Jiewen Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE On 12/10/13 05:51, Yao, Jiewen wrote: > Hi Laszlo > Would you please clarify yo

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Laszlo Ersek
On 12/10/13 05:51, Yao, Jiewen wrote: > Hi Laszlo > Would you please clarify your concern? Does that real happen on some > platforms? Or Do you think it MIGHT happen? > > If it does happen, would please clarify on which platform and why? > > I am trying to understand that... Please see the next

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Yao, Jiewen
Original Message- From: Yao, Jiewen Sent: Tuesday, December 10, 2013 12:52 PM To: edk2-devel@lists.sourceforge.net Subject: RE: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE Hi Laszlo Would you please clarify your concern? Does that real happen on

Re: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Yao, Jiewen
...@redhat.com] Sent: Tuesday, December 10, 2013 11:56 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE This patch enables S3Resume2Pei to eliminate an could be invalid during S3 Resume. The concrete implementation

[edk2] [RFC v2 22/24] UefiCpuPkg: S3Resume2Pei: allow preallocation of PEI_S3_RESUME_STATE

2013-12-09 Thread Laszlo Ersek
This patch enables S3Resume2Pei to eliminate an could be invalid during S3 Resume. The concrete implementation allocates memory from the HOB heap: S3ResumeExecuteBootScript() [UefiCpuPkg/.../S3Resume2Pei/S3Resume.c] AllocatePool() [MdePkg/Library/PeiMemoryAllocationLib] PeiServicesAllocateP