Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-25 Thread Andrew Fish
ilto:tim.le...@insyde.com] > Sent: Wednesday, August 20, 2014 3:39 PM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for > 64-bit right shift > > Mike – > > However, as compilers do require intrinsic fun

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Tim Lewis
[mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 20, 2014 5:31 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Tim, For background, can you please provide a links to the public specification of all

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
5:09 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Mike – The linker errors are the side effect of not putting full support for the compilers in the tree. I don’t want a better error message. I don’t want

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Mcdaniel, Daryl
cated mind to be able to entertain a thought without accepting it." – Aristotle From: Thomas Rognon [mailto:tcrog...@gmail.com] Sent: Wednesday, August 20, 2014 3:58 PM To: edk2-devel Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift I agree with Tim

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Tim Lewis
:59 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Tim, ARM was a different case. Andrew Fish can provide many of the details. Basic issue was that even 32-bit math ops were generating intrinsic calls and

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Mike – However, as compilers do require intrinsic functions in order to support basic C/C++ operators, and as the ArmPkg has already implemented this sort of function for

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
Daryl, Are there subsets of the StdLib that do not depend on the UEFI Shell? Thanks, Mike From: Thomas Rognon [mailto:tcrog...@gmail.com] Sent: Wednesday, August 20, 2014 3:58 PM To: edk2-devel Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift I

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Thomas Rognon
y. > > > > Tim > > > > *From:* Kinney, Michael D [mailto:michael.d.kin...@intel.com] > *Sent:* Wednesday, August 20, 2014 12:30 PM > *To:* edk2-devel@lists.sourceforge.net > *Subject:* Re: [edk2] [StdLib] Patch for review: Add VC++ helper function > for 64-bit right shift > > &

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Tim Lewis
today. Tim From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] Sent: Wednesday, August 20, 2014 12:30 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Thomas, A design decision was made early in the

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Mcdaniel, Daryl
: Wednesday, August 20, 2014 12:30 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Thomas, A design decision was made early in the EDK II project to not depend on any compiler intrinsic functions. The reasons

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Kinney, Michael D
.@intel.com<mailto:daryl.mcdan...@intel.com>] Sent: Wednesday, August 20, 2014 10:56 AM To: edk2-devel@lists.sourceforge.net<mailto:edk2-devel@lists.sourceforge.net> Subject: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Jaben, Erik, or Lee (or anyone else ☺), Ple

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Thomas Rognon
> *Sent:* Wednesday, August 20, 2014 10:56 AM > *To:* edk2-devel@lists.sourceforge.net > *Subject:* [edk2] [StdLib] Patch for review: Add VC++ helper function for > 64-bit right shift > > > > Jaben, Erik, or Lee (or anyone else J), > > Please review the attached patch.

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Tim Lewis
: Wednesday, August 20, 2014 10:56 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift Jaben, Erik, or Lee (or anyone else :)), Please review the attached patch. llshr.c is a new file, LibC.inf was modified. StdLib: Add a

Re: [edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Bjorge, Erik C
Please correct the comment in the c file that states it is shifting to the left and the rest is good. Reviewed-by: Erik Bjorge From: Mcdaniel, Daryl Sent: Wednesday, August 20, 2014 10:56 AM To: edk2-devel@lists.sourceforge.net Subject: [StdLib] Patch for review: Add VC++ helper function for 64

[edk2] [StdLib] Patch for review: Add VC++ helper function for 64-bit right shift

2014-08-20 Thread Mcdaniel, Daryl
Jaben, Erik, or Lee (or anyone else :)), Please review the attached patch. llshr.c is a new file, LibC.inf was modified. StdLib: Add a runtime helper function for VC++ 64-bit right shift on Ia32 target architectures. Add new file StdLib/LibC/CRT/Ia32/llshr.c Add references to the new file to St