:30 AM
To: Wu, Jiaxin
Cc: Fu, Siyuan; Zhang, Lubo; Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [patch] NetworkPkg: Fix an error that the call function
declared implicitly.
Sent from my iPhone
> On Jul 13, 2015, at 7:04 PM, Wu, Jiaxin wrote:
>
> It's used to gen
Sent from my iPhone
> On Jul 13, 2015, at 7:04 PM, Wu, Jiaxin wrote:
>
> It's used to generate any kind of query. This value should be a random value,
> so TSC register maybe called.
>
But that is CPU and platform specific? For example an OS can disable TSC and
this code would break an emu
Got it !
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, July 14, 2015 10:14 AM
To: Fu, Siyuan; Zhang, Lubo; Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: RE: [patch] NetworkPkg: Fix an error that the call function declared
implicitly.
Siyuan, you are right, That is a good sugg
Siyuan, you are right, That is a good suggestion.
Lubo, you can revise the patch to v2 according to Siyuan's opinion.
-Original Message-
From: Fu, Siyuan
Sent: Tuesday, July 14, 2015 10:09 AM
To: Wu, Jiaxin; Zhang, Lubo; Ye, Ting; edk2-devel@lists.sourceforge.net
Subject: RE: [patch] N
Jiaxin
A soft network stack driver should not depend on a platform specific API. If
it's just a random number to identify the message, you could use the NetLib API
NetRandomInitSeed().
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, July 14, 2015 10:04 AM
To: Fu, Siyuan; Zhang, Lub
Why not use some abstraction like the TimerLib?
Sent from my iPhone
> On Jul 13, 2015, at 6:55 PM, Fu, Siyuan wrote:
>
> Lubo,
>
> What's the DnsHeader->Identification means? Why it use the value of TSC
> register?
>
> Siyuan
>
> -Original Message-
> From: Zhang, Lubo
> Sent: Tuesd
It's used to generate any kind of query. This value should be a random value,
so TSC register maybe called.
-Original Message-
From: Fu, Siyuan
Sent: Tuesday, July 14, 2015 9:55 AM
To: Zhang, Lubo; Ye, Ting; Wu, Jiaxin; edk2-devel@lists.sourceforge.net
Subject: RE: [patch] NetworkPkg: Fi
Lubo,
What's the DnsHeader->Identification means? Why it use the value of TSC
register?
Siyuan
-Original Message-
From: Zhang, Lubo
Sent: Tuesday, July 14, 2015 9:50 AM
To: Fu, Siyuan; Ye, Ting; Wu, Jiaxin; edk2-devel@lists.sourceforge.net
Subject: [patch] NetworkPkg: Fix an error that
AsmReadTsc() implementation which is decelerated in BaseLib.h covers both IA32,
X64 and
IPF architecture, so it should specify which implementation to use when invoked.
1. Different Macro definition in DnsImpl.c to specify the implementation.
2. Modefy the NetworkPkg.dsc file to let the DnsDxe
