---------- Forwarded message ----------
From: Ard Biesheuvel <ard.biesheu...@linaro.org>
Date: 8 July 2015 at 11:26
Subject: Re: [edk2] [PATCH v4] ShellPkg: Update ping/ifconfig library.
To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>


On 3 July 2015 at 05:39, jiaxinwu <jiaxin...@intel.com> wrote:
> Version4 include small update from reviewer's comments:
> Change and add some help messages in uni file.
> Revert copyright year in UefiShellNetwork1CommandsLib.c file since there is 
> no code change in this file.
>
> This patch update ShellPkg ping/ifconfig library source code to consume 
> Ip4Config2 protocol.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: jiaxinwu <jiaxin...@intel.com>

This patch breaks the GCC build:

"""
07:03:30 
/home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c:
In function ‘IfConfigShowInterfaceInfo’:
07:03:30 
/home/buildslave/workspace/leg-virt-tianocore-edk2-upstream/edk2/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c:520:14:
error: variable ‘Status’ set but not used
[-Werror=unused-but-set-variable]
07:03:30    EFI_STATUS                Status;
07:03:30               ^
07:03:30 cc1: all warnings being treated as errors
"""

Could you please follow up with a patch that removes Status from this function?

Regards,
Ard.

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to