Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-25 Thread Carsey, Jaben
Go ahead. -Original Message- From: Jordan Justen [mailto:jljus...@gmail.com] Sent: Monday, August 25, 2014 10:20 AM To: Carsey, Jaben; Qiu, Shumin Cc: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-25 Thread Jordan Justen
ted-by: Jordan Justen === -Jordan > From: Andrew Fish [mailto:af...@apple.com] > Sent: Monday, August 25, 2014 9:52 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for > updated class codes > > > > > &g

Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-25 Thread Carsey, Jaben
: ShellPkg: Update 'pci' command for updated class codes On Aug 25, 2014, at 8:41 AM, Carsey, Jaben mailto:jaben.car...@intel.com>> wrote: Do you know why it fails? Is the < or > the incorrect ASCII character? As Lasszio mentioned <96> is not a valid UTF-8 encoding. U+

Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-25 Thread Andrew Fish
On Aug 25, 2014, at 8:41 AM, Carsey, Jaben wrote: > Do you know why it fails? > > Is the < or > the incorrect ASCII character? > As Lasszio mentioned <96> is not a valid UTF-8 encoding. U+0096 is C2 96 in UTF-8. Not to mention U+0096 is a character. So the file contains some non portable

Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-25 Thread Carsey, Jaben
Do you know why it fails? Is the < or > the incorrect ASCII character? -Jaben From: Neeraj Ladkani [mailto:neeraj.ladk...@gmail.com] Sent: Saturday, August 23, 2014 1:24 PM To: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: Regarding commit: ShellPkg: Update 'pci' command for updated c

Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-23 Thread Laszlo Ersek
On 08/23/14 22:23, Neeraj Ladkani wrote: > Hi Jaben, > > The recent commit f056e4c18047e9a0157a915175d07afbd8b8c581(Fri Aug 22 > 17:02:11) is broken on GCC 4.7, > > + { > +0x20, > +L"Ethernet (802.11a <96> 5 GHz)", > +PCIBlankEntry > + }, > + { > +0x21, > +L"Ethernet (802

[edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

2014-08-23 Thread Neeraj Ladkani
Hi Jaben, The recent commit f056e4c18047e9a0157a915175d07afbd8b8c581(Fri Aug 22 17:02:11) is broken on GCC 4.7, + { +0x20, +L"Ethernet (802.11a <96> 5 GHz)", +PCIBlankEntry + }, + { +0x21, +L"Ethernet (802.11b <96> 2.4 GHz)", +PCIBlankEntry + }, Reverting this push bu