Re: [edk2] ShellPkg: Add Dynamic commands into standard command searching

2014-08-05 Thread Bjorge, Erik C
Looks good. You may want to add error handling in place of the asserts in the future. Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Tuesday, August 05, 2014 11:17 AM To: Bjorge, Erik C; Rosenbaum, Lee G; Mcdaniel, Daryl; Cohen, Eugene Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Su

Re: [edk2] ShellPkg: Add Dynamic commands into standard command searching

2014-08-05 Thread Cohen, Eugene
Reviewed-by: Eugene Cohen Thanks again Jaben for integrating the dynamic command stuff. I saw you added the GUID mapping stuff as well, much appreciated. Eugene From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Tuesday, August 05, 2014 12:17 PM To: Bjorge, Erik C; Rosenbaum, Lee G; Mcd

[edk2] ShellPkg: Add Dynamic commands into standard command searching

2014-08-05 Thread Carsey, Jaben
Erik, Lee, Eugene, or Daryl, Can you verify this patch? This searches for handles that produce the dynamic command protocol after searching the commands compiled into the shell. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey UefiShellCommandLib.patch De