Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Shah, Tapan
I proposed a change to remain consistent with the current implementation used for all other error messages which includes %s stuff in it. Thanks, Tapan From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Wednesday, May 14, 2014 11:53 AM To: Shah, Tapan; Bjorge, Erik C Cc: El-Haj-Mahmoud, S

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Carsey, Jaben
I don't mind those changes. I went back and forth between them myself. I went with the former simply because localization hates when we have the %s stuff in the middle of the string. -Jaben From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Wednesday, May 14, 2014 7:36 AM To: Carsey, Jaben; B

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-14 Thread Shah, Tapan
Reviewed-by: Tapan Shah Please fix .uni files with following suggestions: From: #string STR_CP_DEST_OPEN_FAIL #language en-US "%EError. %NThe destination file failed to open with create.%s\r\n" #string STR_CP_DEST_DIR_FAIL #language en-US "%EError. %NThe destination direction could not b

Re: [edk2] ShellPkg: Add error messages to CP when destination file or directory cannot be opened/created

2014-05-13 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge From: Carsey, Jaben Sent: Tuesday, May 13, 2014 3:48 PM To: Bjorge, Erik C; Shah, Tapan (tapands...@hp.com) Cc: El-Haj-Mahmoud, Samer (samer.el-haj-mahm...@hp.com); Lohr, Paul A; edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Add error messages to CP