Re: [edk2] ShellPkg: Patch to enhance the output around GOP protocol

2014-04-29 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni From: Carsey, Jaben Sent: Tuesday, April 29, 2014 12:49 AM To: Ni, Ruiyu Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben Subject: ShellPkg: Patch to enhance the output around GOP protocol Ray, Can you review this? The STR_GOP_DUMP_MAIN string in the UNI is the change

[edk2] ShellPkg: Patch to enhance the output around GOP protocol

2014-04-28 Thread Carsey, Jaben
Ray, Can you review this? The STR_GOP_DUMP_MAIN string in the UNI is the change to that file. ShellPkg: Patch to enhance the output around GOP protocol This patch adds detailed information from the GOP protocol for commands (i.e. DH), that display details about the protocol. Contributed-under

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Carsey, Jaben
reviewed-by: jaben carsey -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Friday, September 20, 2013 8:05 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure Another similar case. ShellPkg: Handle pool

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Sergei Antonov
Another similar case. ShellPkg: Handle pool allocation failure FreePool() will receive NULL if AllocateZeroPool() fails. So a check for NULL is needed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergei Antonov UefiFileHandleLib.c.patch Description: Binary data ---

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Ryan Harkin
l Message- > From: Sergei Antonov [mailto:sap...@gmail.com] > Sent: Thursday, September 19, 2013 3:31 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure > > ShellPkg: Handle pool allocation failure > > If Allocate

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey I will commit this. -Jaben -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Thursday, September 19, 2013 3:31 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure ShellPkg: Handle

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-19 Thread Sergei Antonov
ShellPkg: Handle pool allocation failure If AllocateZeroPool() returns NULL, GetVariable() will return EFI_BUFFER_TOO_SMALL, FreePool() will receive NULL. So check for NULL before FreePool(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergei Antonov SetVar.c.patch D

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-18 Thread Carsey, Jaben
Can you send with the "submitted-by:" and attestation to follow the standard code-submission process? Thanks -Jaben -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Tuesday, September 17, 2013 5:17 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2

[edk2] ShellPkg patch: Handle pool allocation failure

2013-09-17 Thread Sergei Antonov
Hi! See the patch. I get the reason of not checking AllocateZeroPool() return value (GetVariable() will return EFI_BUFFER_TOO_SMALL again). But check before calling FreePool(). SetVar.c.patch Description: Binary data -- L

Re: [edk2] ShellPkg patch

2013-06-21 Thread Cohen, Eugene
ubject: [edk2] ShellPkg patch Eugene, Can you officially review this patch? -Jaben ShellPkg: Update rm command to properly prepend file system identifiers to filenames. This is required when recursively removing directories with files on file systems other than the current one. Contributed

[edk2] ShellPkg patch

2013-06-21 Thread Carsey, Jaben
Eugene, Can you officially review this patch? -Jaben ShellPkg: Update rm command to properly prepend file system identifiers to filenames. This is required when recursively removing directories with files on file systems other than the current one. Contributed-under: TianoCore Contribution A

[edk2] ShellPkg patch: Edit and Hexedit title

2013-01-17 Thread El-Haj-Mahmoud, Samer
Please see attached a patch for some minor fixes to the title bar in EDIT and HEXEDIT shell commands. This removed the "2.0" string, and makes both commands consistent. ShellPkg: Minor change to EDIT and HEXEDIT commands to make the title bars consistent and remove unnecessary "2.0" string