Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Carsey, Jaben
reviewed-by: jaben carsey -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Friday, September 20, 2013 8:05 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure Another similar case. ShellPkg: Handle pool

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Sergei Antonov
Another similar case. ShellPkg: Handle pool allocation failure FreePool() will receive NULL if AllocateZeroPool() fails. So a check for NULL is needed. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergei Antonov UefiFileHandleLib.c.patch Description: Binary data ---

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-20 Thread Ryan Harkin
l Message- > From: Sergei Antonov [mailto:sap...@gmail.com] > Sent: Thursday, September 19, 2013 3:31 AM > To: edk2-devel@lists.sourceforge.net > Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure > > ShellPkg: Handle pool allocation failure > > If Allocate

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey I will commit this. -Jaben -Original Message- From: Sergei Antonov [mailto:sap...@gmail.com] Sent: Thursday, September 19, 2013 3:31 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] ShellPkg patch: Handle pool allocation failure ShellPkg: Handle

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-19 Thread Sergei Antonov
ShellPkg: Handle pool allocation failure If AllocateZeroPool() returns NULL, GetVariable() will return EFI_BUFFER_TOO_SMALL, FreePool() will receive NULL. So check for NULL before FreePool(). Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Sergei Antonov SetVar.c.patch D

Re: [edk2] ShellPkg patch: Handle pool allocation failure

2013-09-18 Thread Carsey, Jaben
] ShellPkg patch: Handle pool allocation failure Hi! See the patch. I get the reason of not checking AllocateZeroPool() return value (GetVariable() will return EFI_BUFFER_TOO_SMALL again). But check before callin

[edk2] ShellPkg patch: Handle pool allocation failure

2013-09-17 Thread Sergei Antonov
Hi! See the patch. I get the reason of not checking AllocateZeroPool() return value (GetVariable() will return EFI_BUFFER_TOO_SMALL again). But check before calling FreePool(). SetVar.c.patch Description: Binary data -- L