Re: [edk2] toolsetupl.bat - Freezer Path Issues

2013-01-23 Thread Cohen, Eugene
Liming, Thanks for acknowledging the issue. I am not a batch file expert so I don't know of a nice way to fix it. Perhaps we should just require that a python freezer is always available and convert this case into an error case to make the user define the python freezer environment variable i

Re: [edk2] toolsetupl.bat - Freezer Path Issues

2013-01-22 Thread Gao, Liming
Eugene: Yes. It is an issue. Seemly, set PATH=%PYTHONPATH%\build;%PYTHONPATH%\GenFds;%PYTHONPATH%\Trim;%PATH% doesn't work in if conditional statement. If it is not in if conditional statement, it can work. For example, command set PATH=%BASE_TOOLS_PATH%\Bin\Win32;%PATH% in BaseTools/toolsetu

[edk2] toolsetupl.bat - Freezer Path Issues

2013-01-22 Thread Cohen, Eugene
In BaseTools/toolsetup.bat there is a series of checks for a python freezer. When I run from a VS command prompt (tested on 2005 and 2012) I found that when we fall through to this case: if not defined PYTHON_FREEZER_PATH ( echo. echo !!! WARNING !!! Will not be able to compile P