Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-02-10 Thread Li, Elvin
014 9:37 AM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function Good comments. Yes. We will fix them. -Original Message- From: Alexei Fedorov [mailto:alexei.fedo...@arm.com] Sent: Thursday, January 30, 2014 7:15 PM To: edk2-

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-02-07 Thread Gao, Liming
Good comments. Yes. We will fix them. -Original Message- From: Alexei Fedorov [mailto:alexei.fedo...@arm.com] Sent: Thursday, January 30, 2014 7:15 PM To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function Liming, I didn'

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-01-30 Thread Alexei Fedorov
Do you plan to implement a patch for issues 1) & 2)? Thanks. Alexei. -- >Message: 6 >Date: Thu, 30 Jan 2014 02:19:18 + >From: "Gao, Liming" >Subject: Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function >To: "edk2-d

Re: [edk2] Bug in TerminalDxe UnicodeFiFoRemoveOneKey() function

2014-01-29 Thread Gao, Liming
Alexei: I agree 1) and 2) are issues. But, they should not happen. Before UnicodeFiFoRemoveOneKey() is called, while statement has checked IsUnicodeFiFoEmpty() to make sure Fifo buffer is not empty. So, UnicodeFiFoRemoveOneKey() doesn't enter into Fifo empty case. Do you meet with the real pr