Re: [edk2] [PATCH v3 5/5] MdeModulePkg; IdeMode select master/slave before diagnostics command

2014-11-06 Thread Tian, Feng
Hi, Reza I did a bigger scope test on your proposed patch. it will bring issue when a HDD is in primary master and a cdrom is in primary slave at Intel DQ57 platform.. The cdrom may be identified as HDD and will get a ABORT error for IDENTIFY cmd. To solve this issue, I modified your code lik

Re: [edk2] [PATCH v2 2/9] IntelFrameworkModulePkg: BdsDxe: poll keyboard at front page with zero timeout

2014-11-06 Thread Dong, Eric
Laszlo, I have checked in my code at r16304. Thanks, Eric -Original Message- From: Jordan Justen [mailto:jordan.l.jus...@intel.com] Sent: Thursday, November 06, 2014 2:16 AM To: Laszlo Ersek; edk2-devel@lists.sourceforge.net Subject: Re: [edk2] [PATCH v2 2/9] IntelFrameworkModulePkg: Bd

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

2014-11-06 Thread Chen, Fan
On Thu, 2014-11-06 at 06:11 +, Fan, Jeff wrote: > Chen, > > Thanks your updating. I attached one addition updating based on you're the > latest patches. Please evaluate and sync it into your patches. > > BTW, please delete ApStartup.asm from CpuDxe, it seems to be one dummy file. Thanks for

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Sergey Isakov
On 06.11.2014, at 11:26, Jordan Justen wrote: > Is NASM just plain incompatible with XCODE? I see no problems. It is compatible with key *_XCODE5_X64_NASM_FLAGS = -f macho64--

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Andrew Fish
> On Nov 6, 2014, at 1:42 AM, Andrew Fish wrote: > >> >> On Nov 6, 2014, at 12:26 AM, Jordan Justen > > wrote: >> >> On 2014-11-05 20:29:46, Andrew Fish wrote: >>> >>>On Nov 5, 2014, at 7:51 PM, Jordan Justen >> > >>>

[edk2] [PATCH v2 1/6] OvmfPkg XenBusDxe: Convert Ia32/hypercall.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert Ia32/hypercall.asm to Ia32/hypercall.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/Ia32/hypercall.S | 22 -- .../Ia32/{hype

[edk2] [PATCH v2 4/6] OvmfPkg XenBusDxe: Convert X64/hypercall.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert X64/hypercall.asm to X64/hypercall.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/X64/hypercall.S | 22 -- .../X64/{hyperca

[edk2] [PATCH v2 2/6] OvmfPkg XenBusDxe: Convert Ia32/InterlockedCompareExchange16.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert Ia32/InterlockedCompareExchange16.asm to Ia32/InterlockedCompareExchange16.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/Ia32/InterlockedCompareExchange16.S

[edk2] [PATCH v2 3/6] OvmfPkg XenBusDxe: Convert Ia32/TestAndClearBit.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert Ia32/TestAndClearBit.asm to Ia32/TestAndClearBit.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/Ia32/TestAndClearBit.S| 13 - ..

[edk2] [PATCH v2 6/6] OvmfPkg XenBusDxe: Convert X64/TestAndClearBit.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert X64/TestAndClearBit.asm to X64/TestAndClearBit.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/X64/TestAndClearBit.S | 12 .../

[edk2] [PATCH v2 0/6] OvmfPkg/XenBusDxe: Convert *.asm to NASM.

2014-11-06 Thread Anthony PERARD
Conversion done using the tools BaseTools/Scripts/ConvertMasmToNasm.py Change in V2: - one commit per assembly source files. Anthony PERARD (6): OvmfPkg XenBusDxe: Convert Ia32/hypercall.asm to NASM OvmfPkg XenBusDxe: Convert Ia32/InterlockedCompareExchange16.asm to NASM OvmfPkg XenBu

[edk2] [PATCH v2 5/6] OvmfPkg XenBusDxe: Convert X64/InterlockedCompareExchange16.asm to NASM

2014-11-06 Thread Anthony PERARD
The BaseTools/Scripts/ConvertMasmToNasm.py script was used to convert X64/InterlockedCompareExchange16.asm to X64/InterlockedCompareExchange16.nasm Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Anthony PERARD --- OvmfPkg/XenBusDxe/X64/InterlockedCompareExchange16.S

Re: [edk2] FE flag in IA32_MTRR_DEF_TYPE MSR

2014-11-06 Thread Brian J. Johnson
On 11/05/2014 09:14 PM, tiger...@via-alliance.com wrote: > Hi, experts: > > I am studying IA32/X64 Programmer manual. > > There is a sentence(Volume-3A, 10.11.5 Section): > > On a hardware reset, the P6 and more recent processors clear the valid > flags in variable-range MTRRs and > > clear the E f

Re: [edk2] [PATCH] [BaseTools] Put all include search paths of a module into a file

2014-11-06 Thread Scott Duplichan
Liu, Yingke D [mailto:yingke.d@intel.com] wrote: ]Dear All, ] ]This patch is going to put all -I or /I options followed by include search path into a ]file (inc.lst) just as object files and static library files. There are cases that too ]many /I options on the command line, and NMAKE fails

Re: [edk2] BeagleBoneBlackPkg: Moving to Intel BDS

2014-11-06 Thread Olivier Martin
What I sometimes do when I have potential problem with EFI device paths, I dump all the EFI device paths available. It is important they exactly match what you are expected to use. From: Varad Gautam [mailto:varadgau...@gmail.com] Sent: 05 November 2014 14:01 To: edk2-devel@lists.sourcefo

[edk2] MdePkg patches to fix Xcode dead stripping issues.

2014-11-06 Thread Andrew Fish
For an assembly function to be stripped by the Xcode linker the .S file must contain the .subsections_via_symbols directive. The edk2 abstracts this away via ASM_FUNCTION_REMOVE_IF_UNREFERENCED.If the .S does not contain a ASM_FUNCTION_REMOVE_IF_UNREFERENCED, then when this library is included thos

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Zimmer, Vincent
I agree. I would keep the original .asm and .s, along w/ new .nasm, at least as part of a transition period of engagement w/ the community. Vincent -Original Message- From: Yao, Jiewen [mailto:jiewen@intel.com] Sent: Wednesday, November 05, 2014 7:23 PM To: Gao, Liming; Justen, Jorda

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Laszlo Ersek
On 11/06/14 20:18, Zimmer, Vincent wrote: > I agree. I would keep the original .asm and .s, along w/ new .nasm, at > least as part of a transition period of engagement w/ the community. > Vincent Well I'm not in a position to argue :), but if .S, .asm, and .nasm[b] files are *all* preserved, then

Re: [edk2] Win32 Compress and UEFI Decompress Question

2014-11-06 Thread Jim_Dailey
Thanks for the suggestion, Andrew. Unfortunately, the decompress protocol doesn't like the gensec compression format either (after I manipulated the header as appropriate). I found some Lzma decompress source and incorporated it into my EFI appp and used LzmaCompress to compress the data that I ap

[edk2] FindImageBase and FVs with 0xff padding.

2014-11-06 Thread Tim Lewis
There are several instances of a function like FindImageBase() (IntelFspWrapperPkg, OvmfPkg/Sec). These functions all share common flaws: 1) If the FV does not begin with a file, then the code does not correctly skip the empty space at the beginning of the FV that is filled with 0xFF. This

Re: [edk2] [PATCH] [BaseTools] Put all include search paths of a module into a file

2014-11-06 Thread Liu, Yingke D
Hi Scott, Thanks for your comments. I will replace '\\' with '/' by using the same rule used in object files and static library files. This patch applied to all sections including [C-Code-File] which is the first several lines in this patch :) Thanks, Dennis -Original Message- From: Sc

Re: [edk2] [RFC PATCH V7 00/27] Introduce Mp Service protocol to UefiCpuPkg

2014-11-06 Thread Fan, Jeff
Chen, Thanks your contribution. I will check-in your patch if there is no further comments from other guys. Reviewed-by: Jeff Fan Thanks! Jeff -Original Message- From: Chen, Fan [mailto:chen.fan.f...@cn.fujitsu.com] Sent: Thursday, November 06, 2014 5:13 PM To: Fan, Jeff Cc: Izumi,

[edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005

2014-11-06 Thread Qiu, Shumin
Hi Jaben, Could you help review the patch? The patch adds type cast to avoid build failure in VS2005. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin mailto:shumin@intel.com>> Thanks, Shumin UefiShellLib.c.patch Description: UefiShellLib.c.patch -

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Jordan Justen
On 2014-11-06 11:18:16, Zimmer, Vincent wrote: > I agree. I would keep the original .asm and .s, along w/ new .nasm, at > least as part of a transition period of engagement w/ the community. > Vincent I think the .asm and .S are harmful if no .inf references them. (Generally speaking, as in anoth

Re: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005

2014-11-06 Thread Qiu, Shumin
Hi Jaben, Patch updated. Could you help review? Thanks, Shumin From: Qiu, Shumin [mailto:shumin@intel.com] Sent: Friday, November 07, 2014 9:27 AM To: Carsey, Jaben Cc: edk2-devel@lists.sourceforge.net Subject: [edk2] [Patch] ShellPkg: Add type cast to avoid build failure in VS2005 Hi Jaben,

Re: [edk2] [PATCH 000/345] Convert EDK II core packages to NASM for IA32/X64

2014-11-06 Thread Kinney, Michael D
Jordan, I would like to understand the XCODE issues with using NASM before we explore tool enhancements. Once we get to a state where a NASM file is fully validated and accepted by all community members for all build environments, I would prefer the INF be updated to only point at NASM file an

Re: [edk2] MdePkg patches to fix Xcode dead stripping issues.

2014-11-06 Thread Gao, Liming
Andrew: Is this a full list? I find some missing .S files in MdePkg, such as BaseCpuLib/X64/CpuSleep.S, BaseMemoryLibSse2/X64/ScanMem8.S. Thanks Liming From: Andrew Fish [mailto:af...@apple.com] Sent: Friday, November 07, 2014 3:15 AM To: edk2-devel@lists.sourceforge.net Subject: [edk2] MdePkg

[edk2] Status of gcc link time optimization for EDK2 use

2014-11-06 Thread Scott Duplichan
http://notabs.org/uefi/gcc-lto.htm Thanks, Scott -- ___ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel