Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-12 Thread Julien Puydt
Damien Sandras a écrit : > I'm using code like this to ensure sane values: > SetAudioJitterDelay (PMAX (min_val, 20), PMIN (max_val, 1000)); That is wrong : you're protecting the call to SetAudioJitterDelay, not the method itself! If I have a method which receives an integer which shouldn't be z

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-12 Thread Damien Sandras
Le vendredi 11 avril 2008 à 11:56 +0200, Matthias Schneider a écrit : > Quoting Damien Sandras <[EMAIL PROTECTED]>: [...] > > > > I think the checks should be done in GMManager::set_video_options too. > > It would prevent crashes. (that is what I do). [...] > I have preferred to do all the chec

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Matthias Schneider
Quoting Julien Puydt <[EMAIL PROTECTED]>: > Hi, > > again, there is a problem with the bridge : it gets something from > gmconf, doesn't check before use, and triggers a floating point exception. > > I'm not sure whether the issue is in ekiga or in opal though : > 0x08132c71 in GMManager::set_vide

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Julien Puydt
Matthias Schneider a écrit : > Quoting Damien Sandras <[EMAIL PROTECTED]>: > >> Le vendredi 11 avril 2008 à 11:26 +0200, Matthias Schneider a écrit : >>> Quoting Julien Puydt <[EMAIL PROTECTED]>: >>> Hi, again, there is a problem with the bridge : it gets something from gmcon

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Matthias Schneider
Quoting Damien Sandras <[EMAIL PROTECTED]>: > Le vendredi 11 avril 2008 à 11:26 +0200, Matthias Schneider a écrit : > > Quoting Julien Puydt <[EMAIL PROTECTED]>: > > > > > Hi, > > > > > > again, there is a problem with the bridge : it gets something from > > > gmconf, doesn't check before use, a

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Damien Sandras
Le vendredi 11 avril 2008 à 11:26 +0200, Matthias Schneider a écrit : > Quoting Julien Puydt <[EMAIL PROTECTED]>: > > > Hi, > > > > again, there is a problem with the bridge : it gets something from > > gmconf, doesn't check before use, and triggers a floating point exception. > > > > I'm not sure

Re: [Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Matthias Schneider
Quoting Julien Puydt <[EMAIL PROTECTED]>: > Hi, > > again, there is a problem with the bridge : it gets something from > gmconf, doesn't check before use, and triggers a floating point exception. > > I'm not sure whether the issue is in ekiga or in opal though : > 0x08132c71 in GMManager::set_vide

[Ekiga-devel-list] Crash in opal-gmconf-bridge.cpp

2008-04-11 Thread Julien Puydt
Hi, again, there is a problem with the bridge : it gets something from gmconf, doesn't check before use, and triggers a floating point exception. I'm not sure whether the issue is in ekiga or in opal though : 0x08132c71 in GMManager::set_video_options (this=0x8303238, [EMAIL PROTECTED]) at