Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread John Smith
On Mon, Apr 14, 2014 at 9:48 PM, Julien Puydt wrote: > > I fixed them too, but I'm quite unhappy: the default C++ constructors were > adequately taking care of things, so those weren't worth it. In fact, to get > more correct core, one should probably *remove* the lines I added, and then > some mo

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread Julien Puydt
Le 14/04/2014 21:06, John Smith a écrit : On Mon, Apr 14, 2014 at 8:27 PM, Julien Puydt wrote: I pushed a commit to fix those in ekiga... I'm actually quite surprised there was so little to complain about! Cool. 'cppcheck' hasnt got much more to complain about either: http://lbalbalba.url.

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread John Smith
On Mon, Apr 14, 2014 at 9:23 PM, Craig Southeren wrote: > On 4/14/14, 12:13 PM, Eugen Dedu wrote: >> >> On 14/04/14 21:08, John Smith wrote: >>> >>> On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu >>> wrote: ptlib and opal are too old to bother with those issues. We are working t

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread Craig Southeren
On 4/14/14, 12:13 PM, Eugen Dedu wrote: On 14/04/14 21:08, John Smith wrote: On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu wrote: ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... I can checkout the latest revisions of ptlib/opal and

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread Eugen Dedu
On 14/04/14 21:08, John Smith wrote: On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu wrote: ptlib and opal are too old to bother with those issues. We are working to use the newest ptlib/opal code... I can checkout the latest revisions of ptlib/opal and run the analyzer on that. Good, please

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread John Smith
On Mon, Apr 14, 2014 at 9:05 PM, Eugen Dedu wrote: > > ptlib and opal are too old to bother with those issues. We are working to > use the newest ptlib/opal code... > I can checkout the latest revisions of ptlib/opal and run the analyzer on that. Regards, John Smith. _

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread John Smith
On Mon, Apr 14, 2014 at 8:27 PM, Julien Puydt wrote: > > I pushed a commit to fix those in ekiga... I'm actually quite surprised > there was so little to complain about! > Cool. 'cppcheck' hasnt got much more to complain about either: http://lbalbalba.url.ph/cppcheck/ekiga/ Regards, John Smith

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread Eugen Dedu
On 14/04/14 20:27, Julien Puydt wrote: Hi, Le 14/04/2014 18:24, John Smith a écrit : Hi, Just for fun, I decided to run the llvm/clang static source code analyzer on ptlib, opal, and ekiga. The results can be found here: ptlib http://lbalbalba.url.ph/clang/ptlib/ opal http://lbalbalba.url

Re: [Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread Julien Puydt
Hi, Le 14/04/2014 18:24, John Smith a écrit : Hi, Just for fun, I decided to run the llvm/clang static source code analyzer on ptlib, opal, and ekiga. The results can be found here: ptlib http://lbalbalba.url.ph/clang/ptlib/ opal http://lbalbalba.url.ph/clang/opal/ ekiga http://lbalbalba.

[Ekiga-devel-list] Static source code analysis of ekiga

2014-04-14 Thread John Smith
Hi, Just for fun, I decided to run the llvm/clang static source code analyzer on ptlib, opal, and ekiga. The results can be found here: ptlib http://lbalbalba.url.ph/clang/ptlib/ opal http://lbalbalba.url.ph/clang/opal/ ekiga http://lbalbalba.url.ph/clang/ekiga/ Regards, John Smith