Re: BigDecimal support

2014-05-07 Thread mooky
There is a more complete pull request here: https://github.com/elasticsearch/elasticsearch/pull/5683 On Saturday, 22 March 2014 00:31:33 UTC, mooky wrote: Fixed. Pull request here: https://github.com/elasticsearch/elasticsearch/pull/5491 -- You received this message because you are

Re: BigDecimal support

2014-03-21 Thread mooky
nick.mi...@gmail.com wrote: I am ready to create a pull request - its actually quite a simple change. However, I cant find *any *tests for the existing BigDecimal support ... does that sound right? -Nick On Friday, 28 February 2014 12:09:00 UTC, mooky wrote: XContentBuilder has support

Re: BigDecimal support

2014-03-21 Thread mooky
Fixed. Pull request here: https://github.com/elasticsearch/elasticsearch/pull/5491 -- You received this message because you are subscribed to the Google Groups elasticsearch group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: BigDecimal support

2014-03-10 Thread mooky
. However, I cant find *any *tests for the existing BigDecimal support ... does that sound right? -Nick On Friday, 28 February 2014 12:09:00 UTC, mooky wrote: XContentBuilder has support for BigDecimal, but: 1. If you pass the source as a Map when indexing, the BigDecimal handling

Re: BigDecimal support

2014-03-05 Thread mooky
I am ready to create a pull request - its actually quite a simple change. However, I cant find *any *tests for the existing BigDecimal support ... does that sound right? -Nick On Friday, 28 February 2014 12:09:00 UTC, mooky wrote: XContentBuilder has support for BigDecimal, but: 1

Re: BigDecimal support

2014-03-05 Thread joergpra...@gmail.com
Yes, there are no tests yet. Jörg On Wed, Mar 5, 2014 at 2:24 PM, mooky nick.minute...@gmail.com wrote: I am ready to create a pull request - its actually quite a simple change. However, I cant find *any *tests for the existing BigDecimal support ... does that sound right? -Nick

Re: BigDecimal support

2014-02-28 Thread mooky
XContentBuilder has support for BigDecimal, but: 1. If you pass the source as a Map when indexing, the BigDecimal handling doesn't get invoked (https://github.com/elasticsearch/elasticsearch/issues/5260). 2. The existing handling should delegate through to Jackson's handling of

BigDecimal support

2014-02-26 Thread mooky
In financial services space, we almost never use float/double in our domain - we always use BigDecimal. In elastic, I would like to be able to index/store BigDecimal in a lossless manner (ie what I get back from _source has the same precision, etc as what I put in). When I have had to

Re: BigDecimal support

2014-02-26 Thread joergpra...@gmail.com
ES accepts BigDecimal input. You can specify scale and rounding mode to format the BigDecimal. https://github.com/jprante/elasticsearch/commit/8ef8cd149b867e3e45bc3055dfd6da80e4e9c7ec Internally, BigDecimal is automatically converted to a JSON string if the number does not fit into double