Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Victor
Coding style is a subjective topic, and that's why discussing which one works best is completely pointless, since it's a matter of preferences. It's like discussing what is the best color. What is important is consistency, and that's why all the new code proposed for merging should follow

[Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread David Gomes
Hello there, There's a class/object/file in Granite called IconFactory.vala, you can check it out here - http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala . Is anybody using it and definitely dependent on it? We're considering removing it

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Victor
You're right Craig, although there's something I still don't understand: Why would somebody want elementary to adapt his/her coding style. It's fine if developers focus on the logic first, using their own coding style, but as a final step those developers should also make sure that their

Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Chris Timberlake
Is there a way to add compile time warnings to it? In the event developers are using it and are unknowing? I'm not knowledgeable about adding compile time warnings in Vala but it might be worth it. On Apr 1, 2013 11:23 AM, Sergey Shnatsel Davidoff ser...@elementaryos.org wrote: I suggest

Re: [Elementary-dev-community] Granite's IconFactory

2013-04-01 Thread Mario Guerriero
Files is using it. — Sent from Mailbox for iPhone On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake gam...@gmail.com wrote: Is there a way to add compile time warnings to it? In the event developers are using it and are unknowing? I'm not knowledgeable about adding compile time warnings in

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread David Gomes
And that's why I use an editor that formats certain things about code for me. On Mon, Apr 1, 2013 at 10:13 PM, Craig webe...@gmail.com wrote: I think you misunderstand me. A prettifier doesn't force the user's style on the project, but it changes the format of the pushed code to match that

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Craig
That's great. It seemed as though you were against a prettifier when you've been using one all along! The next logical step is to migrate to a dedicated tool (one that is not bound to a certain editor) so users are free to use the editor of their liking. If such a tool is available (and is

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread David Gomes
I'm not against prettifiers, I just don't see the need for something like gofmt that aligns comments, indents with tabs and supposedly fixes everything. I'm sure vala-analyzer is good for what we need now and we have other priorities now, but maybe one of these days somebody makes a prettifier,

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Craig
I'm not arguing that gofmt is necessary; anything that facilitates a standard, clear format will suffice. However, I maintain that the vala community would be lucky to have so nice a tool as gofmt. (It really does fix everything) :-P On Apr 1, 2013 4:34 PM, David Gomes da...@elementaryos.org

Re: [Elementary-dev-community] Farewell, Sort Of

2013-04-01 Thread Goncalo Margalho
If you were saying that the 2nd of april I could believe you. In USA is still the 1st. On Tue, Apr 2, 2013 at 1:16 AM, Cassidy James cass...@elementaryos.orgwrote: Hey Awesome Devs, As many of you may or may not know, I joined the elementary team a little over two years ago. I had been

Re: [Elementary-dev-community] Farewell, Sort Of

2013-04-01 Thread Dane Henson
Feels like a punch in the gut. I'm excited for you and proud to have canonical poaching our awesome community members. I wish you the best of luck and hope you continue to haunt these parts. Your prominent presence on the council will be sorely missed. On Apr 1, 2013 7:16 PM, Cassidy James

Re: [Elementary-dev-community] Farewell, Sort Of

2013-04-01 Thread Harvey Cabaguio
Screw you and I hope your family has good health! On Mon, Apr 1, 2013 at 7:22 PM, Dane Henson d...@elementaryos.org wrote: Feels like a punch in the gut. I'm excited for you and proud to have canonical poaching our awesome community members. I wish you the best of luck and hope you continue

Re: [Elementary-dev-community] Farewell, Sort Of

2013-04-01 Thread Daniel Foré
You're hilarious Cassidy :p Best Regards, Daniel Foré El abr 1, 2013, a las 5:16 p.m., Cassidy James cass...@elementaryos.org escribió: Hey Awesome Devs, As many of you may or may not know, I joined the elementary team a little over two years ago. I had been following the project from