Review: Approve
It looks fine - thanks for your work. I didn't test the *BSD part, I assume
that you or Olivier Duchateau tested it.
I am going to merge this with an upper case style (i.e DRAGON_FLY instead of
DragonFly).
--
https://code.launchpad.net/~elementary-dev-community/granite/fix-1324
I don't think we can actually test it on all platforms such as FreeBSD because
they don't have the necessary version of some libs (vala and GTK+ for example).
It doesn't break anything on elementary OS so +1 for merging it.
--
https://code.launchpad.net/~elementary-dev-community/granite/fix-1324
The proposal to merge lp:~elementary-dev-community/granite/fix-1324424 into
lp:granite has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~elementary-dev-community/granite/fix-1324424/+merge/229547
--
https://code.launchpad.net/~elementary-dev
Cameron Norman has proposed merging
lp:~elementary-dev-community/pantheon-terminal/fix-1329550 into
lp:pantheon-terminal.
Requested reviews:
elementary Apps team (elementary-apps)
Related bugs:
Bug #1329550 in Terminal: "Move "About" to quicklist"
https://bugs.launchpad.net/pantheon-termin
Review: Needs Fixing
1. Instead of
43 stdout.printf ("pantheon-terminal: ERROR: " + e.message + "\n");
44
45 return 0;
use
error (e.message);
2. Not sure about the relevant part in the code, but the dark GTK+ theme isn't
active when you start the About-Dialog from the quicklist and
1) is not my code, but I can definitely include that change.
2) This may be a granite deficiency, as the about option here works by relying
on the Granite.Application's behavior when running with the --about option. I
think that when Granite creates the about dialog when the app is already
run
6 matches
Mail list logo
