Re: [Elementary-dev-community] Granite's IconFactory

You should take a look at the code. I don't remember how it is used. — Sent from Mailbox for iPhone On Wed, Apr 3, 2013 at 10:56 PM, David Gomes wrote: > Do you know how hard it would be to make Files stop using IconFactory.vala? > On Mon, Apr 1, 2013 at 7:45 PM, Mario Guerriero wrote: >> Files

Re: [Elementary-dev-community] Granite's IconFactory

Do you know how hard it would be to make Files stop using IconFactory.vala? On Mon, Apr 1, 2013 at 7:45 PM, Mario Guerriero wrote: > Files is using it. > — > Sent from Mailbox for iPhone > > > On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake wrote: > >> Is there a way t

Re: [Elementary-dev-community] Granite's IconFactory

Files is using it. — Sent from Mailbox for iPhone On Mon, Apr 1, 2013 at 8:25 PM, Chris Timberlake wrote: > Is there a way to add compile time warnings to it? > In the event developers are using it and are unknowing? I'm not > knowledgeable about adding compile time warnings in Vala but it might

Re: [Elementary-dev-community] Granite's IconFactory

Yes Chris, it is possible. Vala allows adding annotations to symbols. You only need to add the following annotation at the top of the symbol you want to deprecate.  [Deprecated (replacement = "ReplacementClass", since = "0.3")] class MyDeprecatedClass { ... } On Mon, Apr 1, 2013 at 12:25 PM,

Re: [Elementary-dev-community] Granite's IconFactory

My bad, I was actually referring to "deprecating" it. Moving the file back into Noise is the logically implied action. I'm sorry for deviating the discussion. Regarding the original topic, I'm assuming that the primary reason for the removal (and not deprecation) of IconFactory would be licens

Re: [Elementary-dev-community] Granite's IconFactory

Is there a way to add compile time warnings to it? In the event developers are using it and are unknowing? I'm not knowledgeable about adding compile time warnings in Vala but it might be worth it. On Apr 1, 2013 11:23 AM, "Sergey "Shnatsel" Davidoff" < ser...@elementaryos.org> wrote: > I suggest

Re: [Elementary-dev-community] Granite's IconFactory

I suggest deprecating it instead of removing it right away. 2013/4/1 David Gomes > I can only remove it when Noise stops using it. > > > On Mon, Apr 1, 2013 at 7:21 PM, Victor wrote: > >> I'm sure Mario has used it in many of his projects. >> >> In my humble opinion, that class it not a big de

Re: [Elementary-dev-community] Granite's IconFactory

I can only remove it when Noise stops using it. On Mon, Apr 1, 2013 at 7:21 PM, Victor wrote: > I'm sure Mario has used it in many of his projects. > > In my humble opinion, that class it not a big deal. It's only a > wrapper/facade around one method from GTK+. > > Would you mind removing the S

Re: [Elementary-dev-community] Granite's IconFactory

I'm sure Mario has used it in many of his projects. In my humble opinion, that class it not a big deal. It's only a wrapper/facade around one method from GTK+. Would you mind removing the StatusBar class too? It is hacky, ugly and incomplete and only Noise is using it. On Mon, Apr 1, 2013 a

[Elementary-dev-community] Granite's IconFactory

Hello there, There's a class/object/file in Granite called "IconFactory.vala", you can check it out here - http://bazaar.launchpad.net/~elementary-pantheon/granite/granite/view/head:/lib/Services/IconFactory.vala . Is anybody using it and definitely dependent on it? We're considering removing it