Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Victor
Coding style is a subjective topic, and that's why discussing which one works best is completely pointless, since it's a matter of preferences. It's like discussing what is the best color. What is important is consistency, and that's why all the new code proposed for merging should follow

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Victor
You're right Craig, although there's something I still don't understand: Why would somebody want elementary to adapt his/her coding style. It's fine if developers focus on the logic first, using their own coding style, but as a final step those developers should also make sure that their

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread David Gomes
And that's why I use an editor that formats certain things about code for me. On Mon, Apr 1, 2013 at 10:13 PM, Craig webe...@gmail.com wrote: I think you misunderstand me. A prettifier doesn't force the user's style on the project, but it changes the format of the pushed code to match that

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Craig
That's great. It seemed as though you were against a prettifier when you've been using one all along! The next logical step is to migrate to a dedicated tool (one that is not bound to a certain editor) so users are free to use the editor of their liking. If such a tool is available (and is

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread David Gomes
I'm not against prettifiers, I just don't see the need for something like gofmt that aligns comments, indents with tabs and supposedly fixes everything. I'm sure vala-analyzer is good for what we need now and we have other priorities now, but maybe one of these days somebody makes a prettifier,

Re: [Elementary-dev-community] How to review and merge branches

2013-04-01 Thread Craig
I'm not arguing that gofmt is necessary; anything that facilitates a standard, clear format will suffice. However, I maintain that the vala community would be lucky to have so nice a tool as gofmt. (It really does fix everything) :-P On Apr 1, 2013 4:34 PM, David Gomes da...@elementaryos.org

Re: [Elementary-dev-community] How to review and merge branches

2013-03-31 Thread Sergey Shnatsel Davidoff
I'm afraid automatic prettifiers are a terrible idea because blindly restyling the code usually makes it lose any remains of readability it used to have. In other words, automatically restyled code is even less readable than code with a foreign coding style. 2013/3/31 David Gomes

Re: [Elementary-dev-community] How to review and merge branches

2013-03-31 Thread Craig
How do you figure? The go language community uses one and they rave about it. We use them at work (c++) as well and its uses an obnoxious style, but it's still more readable than a dozen different conventions. On Mar 31, 2013 5:39 AM, Sergey Shnatsel Davidoff ser...@elementaryos.org wrote: I'm