Re: New test for elf_flag{data,ehdr,elf,phdr}

2011-05-07 Thread Roland McGrath
That may get you coverage numbers, but it doesn't really test anything. ___ elfutils-devel mailing list elfutils-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/elfutils-devel

New test for elf_flag{data,ehdr,elf,phdr}

2011-05-07 Thread Marek Polacek
Hi, I've tried to check these functions in just one test, since they are very similar. Thus, I've written the `elf-flag.c' file, which tests them so they are all 100% covered. Tested on x86_64-redhat-linux. OK? Marek 2011-05-07 Marek Polacek * elf-flag.c: New file.

Re: [PATCH] unstrip.c: Mark function as static

2011-05-07 Thread Marek Polacek
On 05/07/2011 07:14 PM, Ulrich Drepper wrote: > If it compiles it's fine. If not we know where to find you. :-) Applied. ___ elfutils-devel mailing list elfutils-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/elfutils-devel

Re: [PATCH] unstrip.c: Mark function as static

2011-05-07 Thread Ulrich Drepper
On Sat, May 7, 2011 at 13:11, Marek Polacek wrote: > The function `compare_sections_nonrel' most probably should be marked > as static.  It is used nowhere else.  Tested on x86_64-redhat-linux.  OK? If it compiles it's fine. If not we know where to find you. _

[PATCH] unstrip.c: Mark function as static

2011-05-07 Thread Marek Polacek
The function `compare_sections_nonrel' most probably should be marked as static. It is used nowhere else. Tested on x86_64-redhat-linux. OK? 2011-05-07 Marek Polacek * unstrip.c (compare_sections_nonrel): Mark this function as static. diff --git a/src/unstrip.c b/src/unstrip.c ind