Re: dwfl_module_get|addrsym_elf (Was: [commit] [patch 2/4] Provide __libdwfl_module_getsym to get dwfl_file *)

2013-11-27 Thread Jan Kratochvil
On Wed, 27 Nov 2013 16:48:16 +0100, Mark Wielaard wrote: > I admit I hadn't thought of that. Now I realize returning the Elf > without the bias is not as useful. For that the dwfl_file is also > useful. But we can still make the simplification you suggest. It looks fine to me. Even with a new tes

Re: dwfl_module_get|addrsym_elf (Was: [commit] [patch 2/4] Provide __libdwfl_module_getsym to get dwfl_file *)

2013-11-27 Thread Mark Wielaard
On Tue, 2013-11-26 at 15:23 +0100, Jan Kratochvil wrote: > Maybe you had a reason for it but we could also just replace > __libdwfl_module_getsym by dwfl_module_getsym_elf now. It would just require > changing > > static inline GElf_Addr > dwfl_deadjust_st_value (Dwfl_Module *mod, struct dwfl_fil

Re: [patchv3 4/4] Provide virtual symbols for ppc64 function descriptors

2013-11-27 Thread Mark Wielaard
On Thu, 2013-11-14 at 20:49 +0100, Jan Kratochvil wrote: > On Thu, 14 Nov 2013 14:42:34 +0100, Mark Wielaard wrote: > > As far as I understand from skimming the code, you want to provide an > > (extra) table of (function) symbols from ebl for the elf file it is > > backing. These symbols are match