Re: [PATCH] libdwfl: linux-pid-attach.c: Report actual PID (Tgid) to dwfl_attach_state.

2013-12-25 Thread Mark Wielaard
On Wed, Dec 25, 2013 at 08:23:25PM +0100, Jan Kratochvil wrote: > On Mon, 23 Dec 2013 14:22:24 +0100, Mark Wielaard wrote: > [...] > > --- a/libdwfl/linux-pid-attach.c > > +++ b/libdwfl/linux-pid-attach.c > > @@ -301,6 +301,27 @@ bool > > internal_function > > __libdwfl_attach_state_for_pid (Dwfl

Re: [PATCH] libdwfl: Make sure to set the CFI return register only once (for ppc64).

2013-12-25 Thread Mark Wielaard
On Wed, Dec 25, 2013 at 08:02:28PM +0100, Jan Kratochvil wrote: > On Sat, 21 Dec 2013 21:56:35 +0100, Mark Wielaard wrote: > > On PPC64 there are two DWARF registers numbers that can represent the > > same register. If that register is the CIE return register then we only > > want to set it once. T

Re: [PATCH] libdwfl: linux-pid-attach.c: Report actual PID (Tgid) to dwfl_attach_state.

2013-12-25 Thread Jan Kratochvil
On Mon, 23 Dec 2013 14:22:24 +0100, Mark Wielaard wrote: [...] > --- a/libdwfl/linux-pid-attach.c > +++ b/libdwfl/linux-pid-attach.c > @@ -301,6 +301,27 @@ bool > internal_function > __libdwfl_attach_state_for_pid (Dwfl *dwfl, pid_t pid) > { > + char buffer[36]; > + FILE *procfile; > + > + /*

Re: [PATCH] libdwfl: Make sure to set the CFI return register only once (for ppc64).

2013-12-25 Thread Jan Kratochvil
On Sat, 21 Dec 2013 21:56:35 +0100, Mark Wielaard wrote: > On PPC64 there are two DWARF registers numbers that can represent the > same register. If that register is the CIE return register then we only > want to set it once. The second setting will confuse the unwinder. OK with the patch. It is