Re: [PATCH] tests: run-backtrace-demangle.sh check exitcode and max number of frames.

2014-01-18 Thread Jan Kratochvil
On Sat, 18 Jan 2014 21:29:40 +0100, Mark Wielaard wrote: > On Sat, Jan 18, 2014 at 07:27:50PM +0100, Jan Kratochvil wrote: > > I agree there should be something like ' || true' but which system cannot > > unwind 'main'? IIUC the 2 frames (and not 3 frames). > > You are right. 3 frames would also

[commit] [patchv2] Fix false FAILs on testsuite with ulimit -c unlimited.

2014-01-18 Thread Jan Kratochvil
On Sat, 18 Jan 2014 21:34:41 +0100, Mark Wielaard wrote: > On Sat, Jan 18, 2014 at 09:01:57PM +0100, Jan Kratochvil wrote: > > tests/ > > 2014-01-18 Jan Kratochvil > > > > Fix false FAILs on testsuite with ulimit -c unlimited. > > * backtrace-child.c (sigusr2): Call pthread_exit. > >

Re: [patch] Detect infinite backtraces

2014-01-18 Thread Jan Kratochvil
On Sat, 18 Jan 2014 21:25:51 +0100, Mark Wielaard wrote: > I don't think it is coincidence that split-stack would work. I believe we > don't assume anything about the stack values and so it should work as > expected since DWARF is expressive enough to describe it. > http://gcc.gnu.org/wiki/SplitSta

Re: [patchv2] Fix false FAILs on testsuite with ulimit -c unlimited.

2014-01-18 Thread Mark Wielaard
On Sat, Jan 18, 2014 at 09:01:57PM +0100, Jan Kratochvil wrote: > On Wed, 15 Jan 2014 18:20:49 +0100, Mark Wielaard wrote: > > I admit it wasn't immediately obvious to me why we were letting the > > child dump core in this case. > > BTW it is a regression since > 70c3a53baa06b6cdee6e92bd673c

Re: [PATCH] tests: run-backtrace-demangle.sh check exitcode and max number of frames.

2014-01-18 Thread Mark Wielaard
On Sat, Jan 18, 2014 at 07:27:50PM +0100, Jan Kratochvil wrote: > On Thu, 16 Jan 2014 09:45:51 +0100, Mark Wielaard wrote: > > There can be more than 3 frames, but depending on the system/installed > > glibc we might not be able to unwind fully till the end. > > cxxfunc -> f -> main > > Expect to s

Re: [patch] Detect infinite backtraces

2014-01-18 Thread Mark Wielaard
Hi, Petr pointed out on irc this patch had slipped through the cracks and hadn't been reviewed yet. Sorry about that. I like the idea, but have some questions on the heuristics used to detect the corrupt stack frame. On Fri, Jan 03, 2014 at 10:18:09PM +0100, Jan Kratochvil wrote: > I have found I

Re: Some stuff for 0.159+

2014-01-18 Thread Jan Kratochvil
On Wed, 15 Jan 2014 22:55:27 +0100, Mark Wielaard wrote: > I forgot about that one. It is completely different from what we provide > since it was designed to be used in-process and doesn't actually do > unwinding (it just uses the system/libgcc _Unwind_Backtrace to get the > raw call stack). Since

[patchv2] Fix false FAILs on testsuite with ulimit -c unlimited.

2014-01-18 Thread Jan Kratochvil
On Wed, 15 Jan 2014 18:20:49 +0100, Mark Wielaard wrote: > I admit it wasn't immediately obvious to me why we were letting the > child dump core in this case. BTW it is a regression since 70c3a53baa06b6cdee6e92bd673c1cf977066bc1 tests: Don't use ptrace detach stopped trick. Raise c

Re: [PATCH] tests: run-backtrace-demangle.sh check exitcode and max number of frames.

2014-01-18 Thread Jan Kratochvil
On Thu, 16 Jan 2014 09:45:51 +0100, Mark Wielaard wrote: > There can be more than 3 frames, but depending on the system/installed > glibc we might not be able to unwind fully till the end. > cxxfunc -> f -> main > Expect to see the top two and a warning that there are more frames > (exit code 1) I