Re: [patch 0/3] Live PIDs with deleted files by /dev/PID/mem

2014-03-02 Thread Jan Kratochvil
On Tue, 25 Feb 2014 23:03:43 +0100, Mark Wielaard wrote: > On Sat, 2014-02-22 at 22:08 +0100, Jan Kratochvil wrote: > > jankratochvil/devmem > > The name, the subject and some of the comments talks about /dev. > But I assume this is really about /proc? Right, there isn't anything related to "dev"

Re: [patch 3/3] Access deleted files by /dev/PID/mem

2014-03-02 Thread Jan Kratochvil
On Tue, 25 Feb 2014 23:56:23 +0100, Mark Wielaard wrote: > - Could we reuse dwfl_pid () instead of adding another pid concept to > struct Dwfl_Module? Then a user could just use dwfl_linux_proc_attach > which might also help us get into the ptrace attach state if needed > for reading /proc/PI

Re: [patch 2/3] Fix abort() on missing section headers

2014-03-02 Thread Jan Kratochvil
On Tue, 25 Feb 2014 23:30:55 +0100, Mark Wielaard wrote: > We certainly shouldn't abort on bad data! > But do we even need to continue at this point? > > return result; means we will keep searching through the section table, > which apparently is busted anyway. So I think it makes sense to cleanup

Re: [patch 1/3] Extend __libdw_open_file and elf_begin as *_at_offset

2014-03-02 Thread Jan Kratochvil
On Tue, 25 Feb 2014 23:12:04 +0100, Mark Wielaard wrote: > I rather not extend the libelf interface if possible. The various libelf > implementations are already a little diverged. Lets not unnecessarily > make the divergence even bigger. I was aware of this issue but I had no other idea. > If p