[PATCH] libdw: Check diridx is valid under DW_LNE_define_file in dwarf_getsrclines.

Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 5 + libdw/dwarf_getsrclines.c | 5 + 2 files changed, 10 insertions(+) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 4f03b73..61c9871 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,5 +1,10 @@ 2014-12-16 Mark

[PATCH] readelf: Print dwarf_errmsg if dwarf_onesrcline or dwarf_linesrc fails.

Don't just crash using the NULL result in print_decoded_line_section. Signed-off-by: Mark Wielaard --- src/ChangeLog | 5 + src/readelf.c | 12 +++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index 7960496..9d14db0 100644 --- a/src/C

[PATCH] libelf: Make sure ar archive long_names len fits in mapped ELF file.

Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 5 + libelf/elf_begin.c | 15 ++- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/libelf/ChangeLog b/libelf/ChangeLog index fe210ab..270579b 100644 --- a/libelf/ChangeLog +++ b/libelf/ChangeLog @@ -1,3 +1,8 @@

[PATCH] libelf: Check index_size doesn't overflow in elf_getarsym.

Signed-off-by: Mark Wielaard --- libelf/ChangeLog | 4 libelf/elf_getarsym.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/libelf/ChangeLog b/libelf/ChangeLog index 7406509..fe210ab 100644 --- a/libelf/ChangeLog +++ b/libelf/ChangeLog @@ -1,5 +1,9 @@ 2014-12-15

Re: [PATCH 1/3] libdw: Make srclines use a stable sort

On 12/16/2014 02:10 AM, Mark Wielaard wrote: >> I think src/elfcmp.c compare_Elf32_Word() is also wrong, as big u32 >> values could wrap int subtraction. I didn't find any others. > > Ah, missed that Elf32_Word is unsigned. There is an assert that makes > sure it is at least as wide as an int, bu

[PATCH] libdw: Make sure there is enough space to read offset in dwarf_getpubnames.

Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 5 + libdw/dwarf_getpubnames.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 0592220..4f03b73 100644 --- a/libdw/ChangeLog +++ b/libdw/ChangeLog @@ -1,5 +1,10 @@ 2014-12-16 Mark Wi

[PATCH] readelf: Correct overflow check for length in print_debug_aranges_section.

Signed-off-by: Mark Wielaard --- src/ChangeLog | 1 + src/readelf.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index 1dc1957..7960496 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -2,6 +2,7 @@ * readelf.c (print_debug_line_sec

[PATCH] readelf, libdw: Correct .debug_line overflow check for unit_length.

Signed-off-by: Mark Wielaard --- libdw/ChangeLog | 5 +++-- libdw/dwarf_getsrclines.c | 4 ++-- src/ChangeLog | 5 + src/readelf.c | 4 ++-- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/libdw/ChangeLog b/libdw/ChangeLog index 757fb23..05922

Re: [PATCH] libdw: pre-compute leb128 loop limits

On Mon, 2014-12-15 at 23:03 +0100, Mark Wielaard wrote: > On Mon, 2014-12-15 at 22:42 +0100, Mark Wielaard wrote: > > On Mon, 2014-12-15 at 12:18 -0800, Josh Stone wrote: > > > On Fedora 21, this appears to be slightly faster, although pretty close > > > to noise levels. Mark, can you see if this

Re: [PATCH] libdwfl: Make sure elf_getdata_rawchunk size_t doesn't overflow find_dynsym.

On Sat, 2014-12-13 at 22:29 +0100, Mark Wielaard wrote: > +2014-12-13 Mark Wielaard > + > + * dwfl_module_getdwarf.c (find_dynsym): elf_getdata_rawchunk takes > + a size_t, make sure it doesn't overflow. I pushed this to master.

Re: [PATCH] libdw: Make sure end of next cu doesn't overflow section data size.

On Fri, 2014-12-12 at 00:25 +0100, Mark Wielaard wrote: > An invalid or trucated debug info/type section could cause the cu endp > to point beyond the end of section data. > > 2014-12-11 Mark Wielaard > > + * libdw_findcu.c (__libdw_intern_next_unit): Sanity check offset. I pushed this t

Re: [PATCH 1/3] libdw: Make srclines use a stable sort

On Mon, 2014-12-15 at 13:48 -0800, Josh Stone wrote: > On 12/13/2014 03:18 PM, Mark Wielaard wrote: > > On Thu, Dec 11, 2014 at 05:34:06PM -0800, Josh Stone wrote: > >> It might be worth auditing other qsort/tsearch comparison functions for > >> similar wrapping possibilities. > > > > I think you