Josh Stone writes:
> With CFLAGS='-Og -g', F21 gcc hits -Werror=maybe-uninitialized on jmp in
> the call "prepare_thread (pid2, jmp)". It's fine with -O2/-O0.
>
> The only way this could be unset is if the loop before ran to
> completion, and there's already an assert against this case.
GCC is
Josh Stone writes:
> With CFLAGS='-Og -g', F21 gcc hits -Werror=maybe-uninitialized in
> read_encoded_value at "*result += value". It's fine with -O2/-O0.
>
> By my inspection, the only way those don't set value are for error
> cases, which will then return immediately.
Looks good to me. I don
Roland McGrath writes:
> That looks OK to me, but the #include seems extraneous.
It's a leftover from debugging printfs, that I forgot to remove.
I removed it now and pushed.
Thanks,
Petr
With CFLAGS='-Og -g', F21 gcc hits -Werror=maybe-uninitialized on jmp in
the call "prepare_thread (pid2, jmp)". It's fine with -O2/-O0.
The only way this could be unset is if the loop before ran to
completion, and there's already an assert against this case.
This patch initializes jmp anyway to
With CFLAGS='-Og -g', F21 gcc hits -Werror=maybe-uninitialized in
read_encoded_value at "*result += value". It's fine with -O2/-O0.
In particular it seems to care about the __libdw_cfi_read_address_inc
calls. By my inspection, the only way those don't set value are for
error cases, which will th
That looks OK to me, but the #include seems extraneous.
- Instead of bailing out at iteration start, we remember the
base-address-selecting attributes were not seen, and then bail out
later if no base address selection entry has been seen.
Signed-off-by: Petr Machata
---
libdw/ChangeLog | 7 +
libdw/dwarf_ranges.c
