> In the case we mmap'd the code at the top of the function would already
> have triggered and returned the ELF image because the whole file would
> already been read in/mmap'd in memory. So if we get to the build-id
> check we know that either the file is big and incomplete, or not eagerly
> read
On Mon, 2015-03-23 at 22:46 +0100, Mark Wielaard wrote:
> Don't explicitly extend the file size for SHT_NOBITS sections. Since
> that could cause a size beyond any actual file content it will cause
> issues when the underlying ELF file has been mmapped or will extend
> the file size to increase (wr
On Mon, 2015-03-23 at 15:20 +0100, Mark Wielaard wrote:
> When building with relro aarch64 splits .got in a writable and read-only
> part. _GLOBAL_OFFSET_TABLE_ points to the first writable symbol, not the
> start of .got.
I pushed this to master.
On Thu, 2015-03-19 at 13:51 -0700, Roland McGrath wrote:
> The XXX comment right above there says what we really want. It should have
> the read-from-core option in its back pocket and do that only when locating
> a disk file by build-id failed. I've lost track now of how much
> refactoring would
Mark Wielaard writes:
> On Wed, 2015-03-18 at 00:55 +0100, Petr Machata wrote:
>> these iterators originated a couple years back on the dwarflint branch.
>> Back then Roland added some C++ wrappers and we started writing stuff in
>> C++. I've been lugging them around ever since, first to dwlocst
On Wed, 2015-03-18 at 20:05 +0100, Petr Machata wrote:
> - Make the macro names properly scoped (DWARF_ALL_KNOWN_* and
> DWARF_ONE_KNOWN_*).
>
> - Simplify the calling convention: don't keep track of the comment
> associated with the enumerator, always use the non-_DESC
> DWARF_ONE_KNOWN_* c
I haven't done a full review, but I can answer one of your questions:
On 03/27/2015 07:13 AM, Mark Wielaard wrote:
>> +cu_iterator
>> +operator++ ()
>> +{
>> + move ();
>> + return *this;
>> +}
>> +
>> +cu_iterator
>> +operator++ (int)
>> +{
>> + cu_itera
Hi,
Sorry for the late reply. I had hoped someone with a bit more C++ foo
would comment first. Apologies for some of the basic questions. Assume
my C++ foo is below zero.
On Wed, 2015-03-18 at 00:55 +0100, Petr Machata wrote:
> these iterators originated a couple years back on the dwarflint branc
