Re: [PATCH] libelf: Use possix_fallocate instead of ftruncate to extend ELF file.

2015-05-14 Thread Josh Stone
On 05/14/2015 03:44 AM, Mark Wielaard wrote: > diff --git a/libelf/ChangeLog b/libelf/ChangeLog > index 2d10b83..5e7b104 100644 > --- a/libelf/ChangeLog > +++ b/libelf/ChangeLog > @@ -1,3 +1,8 @@ > +2015-05-14 Mark Wielaard > + > + * elf_update.c (write_file): Use possix_fallocate instead of

Re: [PATCH 0/4] Improve elfutils diagnostics

2015-05-14 Thread Mark Wielaard
Hi Jonathan, Sorry for the brief reply, I am somewhat offline today, but wanted to give some quick feedback. Apologies if it is too brief or not too well thought out. In that case I'll take more time to think things through tomorrow. On Wed, May 13, 2015 at 02:44:50PM -0400, Jonathan Lebon wrote:

Re: [PATCH 0/4] Improve elfutils diagnostics

2015-05-14 Thread Mark Wielaard
On Wed, May 13, 2015 at 01:31:00PM -0400, Frank Ch. Eigler wrote: > > One implementation detail that I like to see changed is to make the > > details errmsg a list of strings instead of one big string (and > > similarly for dw_tried_paths). [...] > > How would such a list-of-strings be represented

Re: Getting rid of portable branch (Was: [PATCH 3/6] Fall back on utimes if futimes is not available)

2015-05-14 Thread Mark Wielaard
On Wed, May 13, 2015 at 12:17:58PM -0400, Frank Ch. Eigler wrote: > > [...] because you guys (reasonably) cannot test every gcc/C library > > version/flags/arch combination. [...] > > Exactly - and even we encountered the downsides of this as > fedora/rawhide moved between different patches of g

Re: Getting rid of portable branch (Was: [PATCH 3/6] Fall back on utimes if futimes is not available)

2015-05-14 Thread Mark Wielaard
Hi Mike, On Wed, May 13, 2015 at 12:09:50PM -0400, Mike Frysinger wrote: > On 13 May 2015 16:18, Mark Wielaard wrote: > > On Thu, 2015-05-07 at 22:08 -0400, Mike Frysinger wrote: > > > > If there are specific hacks you would like to see brought over from the > > > > portable branch to master, plea

[PATCH] libelf: Use possix_fallocate instead of ftruncate to extend ELF file.

2015-05-14 Thread Mark Wielaard
This fixes an obscure SIGBUS error when using ELF_C_WRITE_MMAP on an ELF file that needs extending when the underlying file system is (nearly) full. Use posix_fallocate to make sure the file content is really there. Using ftruncate might mean the file is extended, but space isn't allocated yet. Th