Re: [PATCH] Do without union of variable length arrays.

2015-09-30 Thread Chih-hung Hsieh
Please review the new attached 0004*patch file. Compared with previous 0003-Do-without-union-of-variable-length-arrays.patch the new 0004-* patch has: * Synced in latest elfutils. * Updated changes to ChangeLog files. * Checked overflow before malloc or xmalloc: xmalloc(shdr_bytes) in src/un

Re: [PATCH] Move 4 libdwfl nested functions.

2015-09-30 Thread Roland McGrath
I just skimmed but it looks reasonable to me.

Re: [PATCH] Move 4 libdwfl nested functions.

2015-09-30 Thread Chih-hung Hsieh
Mark, Roland, How do you think about this patch? Is this an acceptable way to convert nested functions? On Fri, Sep 18, 2015 at 11:25 AM, Chih-Hung Hsieh wrote: > Now they should compile with clang. > > Used local variables are passed to new file scope functions > as constant parameters, or po