Re: [PATCH] Improve AM_SILENT_RULES coverage

2015-10-06 Thread Josh Stone
On 10/06/2015 03:02 PM, Mark Wielaard wrote: > On Tue, 2015-10-06 at 10:23 -0700, Josh Stone wrote: >> On 10/06/2015 06:00 AM, Mark Wielaard wrote: >>> On Mon, 2015-10-05 at 11:15 -0700, Josh Stone wrote: Note, elfutils does not explicitly enable AM_SILENT_RULES. It's only available star

Re: [PATCH] Do without union of variable length arrays.

2015-10-06 Thread Alexander Cherepanov
On 2015-10-07 02:17, Chih-hung Hsieh wrote: > +if (unlikely (phnum > > + SIZE_MAX / MAX (sizeof (Elf32_Phdr), sizeof (Elf64_Phdr > + return DWFL_E_NOMEM; > +const size_t phdrs_bytes = > +phnum * MAX (sizeof (Elf32_Phdr), sizeof (Elf64_Phdr)); > +void

Re: [PATCH] Do without union of variable length arrays.

2015-10-06 Thread Alexander Cherepanov
On 2015-10-05 21:45, Mark Wielaard wrote: On Fri, Oct 02, 2015 at 12:10:47AM +0300, Alexander Cherepanov wrote: On 2015-09-16 18:25, Mark Wielaard wrote: On Fri, 2015-09-11 at 12:22 -0700, Roland McGrath wrote: It looks fine to me from a quick skim, but Mark should review and test it too. I

Re: [PATCH] Do without union of variable length arrays.

2015-10-06 Thread Chih-hung Hsieh
Mark, I appreciate your efforts to make these and other changes about nested functions. We can see soon elfutils will compile with clang/llvm on Android. Please take a look of the new attached 0007*patch. Thanks. On Tue, Oct 6, 2015 at 2:25 PM, Mark Wielaard wrote: > On Mon, 2015-10-05 at 14:1

Re: [PATCH 1/5] Use -fPIC instead of -fpic when generating PIC code.

2015-10-06 Thread Jose E. Marchesi
> If the change bothers the ppc folks we can always discriminate by > host_cpu in configure.ac and subst a $(PIC_FLAG) accordingly... I asked around and it seems at least for ppc64[le] there were no concerns. So I just pushed your change to go with -fPIC for every arch to

Re: [PATCH] Improve AM_SILENT_RULES coverage

2015-10-06 Thread Mark Wielaard
On Tue, 2015-10-06 at 10:23 -0700, Josh Stone wrote: > On 10/06/2015 06:00 AM, Mark Wielaard wrote: > > On Mon, 2015-10-05 at 11:15 -0700, Josh Stone wrote: > >> Note, elfutils does not explicitly enable AM_SILENT_RULES. It's only > >> available starting from automake 1.11 > > > > Note that we al

Re: [PATCH 2/5] sparc: support for the check_object_attribute ebl hook.

2015-10-06 Thread Mark Wielaard
On Tue, 2015-10-06 at 16:20 +0200, Jose E. Marchesi wrote: > > sparc: support for the check_object_attribute ebl hook. > > This makes elfutils based utilities to be aware of the ELF attribute > tags defined in sparc targets. > > Signed-off-by: Jose E. Marchesi Thanks, p

Re: [PATCH 1/5] Use -fPIC instead of -fpic when generating PIC code.

2015-10-06 Thread Mark Wielaard
On Tue, 2015-10-06 at 14:25 +0200, Jose E. Marchesi wrote: > If the change bothers the ppc folks we can always discriminate by > host_cpu in configure.ac and subst a $(PIC_FLAG) accordingly... I asked around and it seems at least for ppc64[le] there were no concerns. So I just pushed your change t

Re: [PATCH] Do without union of variable length arrays.

2015-10-06 Thread Mark Wielaard
On Mon, 2015-10-05 at 14:15 -0700, Chih-hung Hsieh wrote: > Please review attached 0006*patch with the new changed I mentioned > previously. Thanks. Very nice. Now we get to keep the array bounds. You forgot them in one place though: > diff --git a/libelf/elf_getarsym.c b/libelf/elf_getarsym.c >

Re: [PATCH] Improve AM_SILENT_RULES coverage

2015-10-06 Thread Josh Stone
On 10/06/2015 06:00 AM, Mark Wielaard wrote: > On Mon, 2015-10-05 at 11:15 -0700, Josh Stone wrote: >> Note, elfutils does not explicitly enable AM_SILENT_RULES. It's only >> available starting from automake 1.11 > > Note that we already require 1.11 or higher for parallel-tests. > I wouldn't min

Re: [PATCH 2/5] sparc: support for the check_object_attribute ebl hook.

2015-10-06 Thread Jose E. Marchesi
On Mon, Oct 05, 2015 at 05:36:31PM +0200, Jose E. Marchesi wrote: > This makes elfutils based utilities to be aware of the ELF attribute > tags defined in sparc targets. Are the hwcap values specified somewhere? If so it would be good to add an URL to the specification. N

Re: [PATCH] Improve AM_SILENT_RULES coverage

2015-10-06 Thread Mark Wielaard
On Mon, 2015-10-05 at 11:15 -0700, Josh Stone wrote: > Note, elfutils does not explicitly enable AM_SILENT_RULES. It's only > available starting from automake 1.11 Note that we already require 1.11 or higher for parallel-tests. I wouldn't mind if we also just added AM_SILENT_RULES([yes]) by defau

Re: [PATCH 1/5] Use -fPIC instead of -fpic when generating PIC code.

2015-10-06 Thread Jose E. Marchesi
> > This avoids relocation overflows in sparc/sparc64 targets while > > linking, where the reachable data using -fpic is only 4kb. > > I think this is OK. -fpic/-fPIC only changes things on m68k, PowerPC > and SPARC. So the only other arch we currently su

Re: [PATCH 0/5] A few sparc fixes

2015-10-06 Thread Mark Wielaard
On Mon, 2015-10-05 at 17:36 +0200, Jose E. Marchesi wrote: > Hello. This small patch series fixes several issues in sparc-*-* and > sparc64-*-* targets. > > Jose E. Marchesi (5): > Use -fPIC instead of -fpic when generating PIC code. > sparc: support for the check_object_attribute ebl hook. >

Re: [PATCH 1/5] Use -fPIC instead of -fpic when generating PIC code.

2015-10-06 Thread Mark Wielaard
On Mon, 2015-10-05 at 23:57 +0200, Jose E. Marchesi wrote: > > This avoids relocation overflows in sparc/sparc64 targets while > > linking, where the reachable data using -fpic is only 4kb. > > I think this is OK. -fpic/-fPIC only changes things on m68k, PowerPC > and SPARC.