On 10/09/2015 06:03 PM, Roland McGrath wrote:
> Let's drop while we're there. Anybody broken by that (unless
> I overlooked some use of such a type in libelf.h itself) deserves to be.
That breaks size_t all over the place, so we at least need stddef.h.
Then Elf_Arhdr breaks 4 more: time_t, uid_
Let's drop while we're there. Anybody broken by that (unless
I overlooked some use of such a type in libelf.h itself) deserves to be.
> > Yeah, that sounds like a wise fear. But maybe Elf64_Off is OK (and
> > preferable even) for the cases that are not return values?
>
> In practice we're limited to 2^63-1 off_t anyway, so the only benefit
> would be enforcing that they can't be negative, right?
And the types being sane for th
Some systems don't have loff_t, like FreeBSD where off_t always supports
large files. We need a standardized 64-bit signed type for the public
header, without depending on configuration... OK, just use int64_t.
Signed-off-by: Josh Stone
---
libelf/ChangeLog | 4
libelf/libelf.h | 13
On 10/09/2015 02:57 PM, Roland McGrath wrote:
>> However, I'm afraid to change signedness, if only because -1 is used in
>> error conditions, e.g. returned from elf_update(). Someone checking <0
>> will be in for a bad time.
>
> Yeah, that sounds like a wise fear. But maybe Elf64_Off is OK (and
> However, I'm afraid to change signedness, if only because -1 is used in
> error conditions, e.g. returned from elf_update(). Someone checking <0
> will be in for a bad time.
Yeah, that sounds like a wise fear. But maybe Elf64_Off is OK (and
preferable even) for the cases that are not return va
On 10/09/2015 01:57 PM, Roland McGrath wrote:
> Hmm. Is it the case that loff_t or off_t that we want to use will always
> be 64 bits? The way we use it in the libelf interfaces always wants a
> positive offset (or size). I don't think change of signedness really needs
> to count as an ABI chang
Hmm. Is it the case that loff_t or off_t that we want to use will always
be 64 bits? The way we use it in the libelf interfaces always wants a
positive offset (or size). I don't think change of signedness really needs
to count as an ABI change here. Could we just use Elf64_Off and be done
with
On 10/09/2015 01:24 PM, Roland McGrath wrote:
> I really don't like having the big header that we actually hack on be the
> massaged file (not that it's changed often in years, but anyway). Can you
> make the configure-generated thing be just a tiny header that's included
> by libelf.h instead?
S
I really don't like having the big header that we actually hack on be the
massaged file (not that it's changed often in years, but anyway). Can you
make the configure-generated thing be just a tiny header that's included
by libelf.h instead?
Some systems don't have loff_t, like FreeBSD where off_t always supports
large files. We can use AC_CHECK_TYPE to support this, with an AC_SUBST
to create a libelf.h specialized for the target system.
Signed-off-by: Josh Stone
---
ChangeLog| 7 +
backends/ChangeLog | 4 +
back
On 10/09/2015 04:17 AM, Mark Wielaard wrote:
> On Thu, 2015-10-08 at 13:05 -0700, Josh Stone wrote:
>> AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in config.h if needed for
>> LFS, and this automatically maps things like open to open64. But quite
>> a few places used explicit 64-bit names, which wo
On Fri, 2015-10-09 at 14:16 +0200, Jose E. Marchesi wrote:
> commit c5d24f902b7d97d57fe72cece3983d02efd91c5f
> Author: Jose E. Marchesi
> Date: Fri Oct 9 08:09:00 2015 -0400
>
> Do not rely on ebl_check_special_section when checking debuginfo files.
>
> The test run-strip-strmerge.
On Fri, 2015-10-09 at 12:51 +0200, Jose E. Marchesi wrote:
> Hi. This little patch fixes two warnings raised by GCC 4.4.7:
> declaration of ‘check’ shadows a global declaration
>
> commit 885b420ec0973467d7fc3d5719a1d5cda789cf59
> Author: Jose E. Marchesi
> Date: Fri Oct 9 06:50:30 2015 -0400
On Fri, 2015-10-09 at 12:35 +0200, Jose E. Marchesi wrote:
> Here you go.
>
> commit 43f68c295e60ca716bc5d1a3876c62f949d4f889
> Author: Jose E. Marchesi
> Date: Fri Oct 9 06:38:39 2015 -0400
>
> Use seek+read instead of pread to read from /dev/$$/mem files.
>
> pread[64] always re
commit c5d24f902b7d97d57fe72cece3983d02efd91c5f
Author: Jose E. Marchesi
Date: Fri Oct 9 08:09:00 2015 -0400
Do not rely on ebl_check_special_section when checking debuginfo files.
The test run-strip-strmerge.sh is failing in sparc targets. This is
because it does an `elflint
On Thu, 2015-10-08 at 13:05 -0700, Josh Stone wrote:
> AC_SYS_LARGEFILE defines _FILE_OFFSET_BITS in config.h if needed for
> LFS, and this automatically maps things like open to open64. But quite
> a few places used explicit 64-bit names, which won't work on platforms
> like FreeBSD where off_t i
Hi. This little patch fixes two warnings raised by GCC 4.4.7:
declaration of ‘check’ shadows a global declaration
commit 885b420ec0973467d7fc3d5719a1d5cda789cf59
Author: Jose E. Marchesi
Date: Fri Oct 9 06:50:30 2015 -0400
Avoid a shadowing declaration warning with GCC 4.4.
Sign
This subtly changes the code to always ignore errors and turns them into
"short reads" instead. Looking at how this code is used I think it is
actually better to instead change the code to report an error with errno.
So return -1 from lseek and just fall through to returning -1 aft
On Thu, 2015-10-08 at 11:19 -0700, Chih-hung Hsieh wrote:
> Mark,
>
> Could you take a look of the attached 0002*patch file?
> Only one typo in 0001*patch was fixed and I synced with latest source.
>
> I am going to clean up and split my previous patches for nested functions
> into smaller pieces
Some older compilers warn about a function and argument name being equal.
Signed-off-by: Mark Wielaard
---
tests/ChangeLog | 5 +
tests/elfshphehdr.c | 8
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 66781d0..523a350 1006
On Mon, 2015-10-05 at 00:12 +0200, Mark Wielaard wrote:
> We can only sanity check the symbols to discarded sections when creating a
> debug file. Otherwise we won't keep track of debug_data. This can trigger
> erroneously when there are relocation symbols in the symtab for a .debug
> section but w
22 matches
Mail list logo
