Re: [PATCH] Move 4 libdwfl nested functions.

2015-10-05 Thread Mark Wielaard
On Fri, 2015-09-18 at 11:25 -0700, Chih-Hung Hsieh wrote: > Now they should compile with clang. > > Used local variables are passed to new file scope functions > as constant parameters, or pointers, or embedded in a > 'state' structure. > > One simple function "report" is changed to a macro. > It

Re: [PATCH] Move 4 libdwfl nested functions.

2015-09-30 Thread Roland McGrath
I just skimmed but it looks reasonable to me.

Re: [PATCH] Move 4 libdwfl nested functions.

2015-09-30 Thread Chih-hung Hsieh
Mark, Roland, How do you think about this patch? Is this an acceptable way to convert nested functions? On Fri, Sep 18, 2015 at 11:25 AM, Chih-Hung Hsieh wrote: > Now they should compile with clang. > > Used local variables are passed to new file scope functions > as constant parameters, or po

[PATCH] Move 4 libdwfl nested functions.

2015-09-18 Thread Chih-Hung Hsieh
Now they should compile with clang. Used local variables are passed to new file scope functions as constant parameters, or pointers, or embedded in a 'state' structure. One simple function "report" is changed to a macro. It triggers a gcc false positive -Werror=maybe-uninitialized, so the local v