Re: [PATCH] Avoid double-including config.h

2017-05-04 Thread Ulf Hermann
On 05/02/2017 01:55 PM, Ulf Hermann wrote: >> Maybe we can cleanup that last >> one once we integrate gnulib (which I believe has a good/64-off_t fts.h >> already). > > gnulib is among the bad ones. Or, at least we detect it as bad. Sorry, I meant the msys fts.h. That is also the one which needs

Re: [PATCH] Avoid double-including config.h

2017-05-02 Thread Ulf Hermann
Maybe we can cleanup that last one once we integrate gnulib (which I believe has a good/64-off_t fts.h already). gnulib is among the bad ones. Or, at least we detect it as bad. Ulf

Re: [PATCH] Avoid double-including config.h

2017-05-02 Thread Mark Wielaard
On Thu, 2017-04-20 at 16:31 +0200, Ulf Hermann wrote: > config.h doesn't have include guards, so including it twice is bad. We > deal with this by checking for PACKAGE_NAME, but only in some places. > Once we start using gnulib, we will need to include config.h before any > gnulib-generated headers

[PATCH] Avoid double-including config.h

2017-04-20 Thread Ulf Hermann
config.h doesn't have include guards, so including it twice is bad. We deal with this by checking for PACKAGE_NAME, but only in some places. Once we start using gnulib, we will need to include config.h before any gnulib-generated headers. This is problematic if we include it transitively through ou