Re: [PATCH] debuginfod: Use the debuginfod-size response header

2022-04-25 Thread Aaron Merey via Elfutils-devel
On Sun, Apr 24, 2022 at 11:05 AM Mark Wielaard wrote: > Looks good. Pleas commit. Thanks, pushed as: commit 55fee962676fbff60c6b0469305bcb077910d64f Author: Aaron Merey Date: Tue Jan 11 22:07:55 2022 -0500 debuginfod: Use the debuginfod-size response header In some cases the content

Re: [PATCH] debuginfod: Use the debuginfod-size response header

2022-04-24 Thread Mark Wielaard
Hi Aaron, On Fri, Apr 22, 2022 at 06:56:41PM -0400, Aaron Merey via Elfutils-devel wrote: > I've updated the patch below with the changes Mark recommended. > > A couple X-DEBUGINFOD-SIZE tests were added in another patch I recently > posted [1] that also fixes a bug when computing this header's v

Re: [PATCH] debuginfod: Use the debuginfod-size response header

2022-04-22 Thread Aaron Merey via Elfutils-devel
I've updated the patch below with the changes Mark recommended. A couple X-DEBUGINFOD-SIZE tests were added in another patch I recently posted [1] that also fixes a bug when computing this header's value for an archived file. Aaron [1] https://sourceware.org/pipermail/elfutils-devel/2022q2/0049

Re: [PATCH] [PATCH] debuginfod: Use the debuginfod-size response header

2022-04-21 Thread Aaron Merey via Elfutils-devel
On Thu, Mar 31, 2022 at 1:44 PM Mark Wielaard wrote: > Just a question about this part: > > > + /* If Content-Length is -1, try to get the size from > > + X-Debuginfod-Size */ > > + if (dl_size == -1 && c->winning_headers != NULL) > > +{ > > +

Re: [PATCH] [PATCH] debuginfod: Use the debuginfod-size response header

2022-03-31 Thread Mark Wielaard
Hi Aaron, On Tue, 2022-01-11 at 22:07 -0500, Aaron Merey via Elfutils-devel wrote: > In some cases the content-length header may not be available in order > to pass to a progressfn. If content-length isn't available then attempt > to get the size of the download from the debuginfod-size header in

[PATCH] [PATCH] debuginfod: Use the debuginfod-size response header

2022-01-11 Thread Aaron Merey via Elfutils-devel
In some cases the content-length header may not be available in order to pass to a progressfn. If content-length isn't available then attempt to get the size of the download from the debuginfod-size header instead. It should be mentioned that if a compressed file (ex. gzip) is being transferred,