Re: More bugs in Custom themes

2005-07-25 Thread Richard M. Stallman
Very non-trivial questions remain, like how Custom Themes is going to treat hooks and certain list variables. At present, even without Themes, Custom has serious problems handling these, as we discussed earlier. There is no need to worry about it--since they did not work cleanly

Re: More bugs in Custom themes

2005-07-25 Thread Per Abrahamsen
Luc Teirlinck <[EMAIL PROTECTED]> writes: > Sorry for the delay in replying to this. > >Could you please look at the code and see if the design is clear >to you? > > I have not had the time to study things in detail, but the design is > certainly clearer than what it used to be. Very non-

Re: More bugs in Custom themes

2005-07-24 Thread Luc Teirlinck
Sorry for the delay in replying to this. Could you please look at the code and see if the design is clear to you? I have not had the time to study things in detail, but the design is certainly clearer than what it used to be. Very non-trivial questions remain, like how Custom Themes is goi

Re: More bugs in Custom themes

2005-07-10 Thread Richard M. Stallman
but I think we already discussed the proper conflict resolution method. What I suggested was that the themes are listed in an order, and later themes override earlier themes. It is a little bit more complex than that. The user can enable or disable themes, save optio

Re: More bugs in Custom themes

2005-07-10 Thread Richard M. Stallman
I rewrote most of the themes code in custom.el. I did not have time to debug it ;-(, but I verified that Emacs still at least builds and runs. Whether or not it is bug-free, at least now it should have a clear design that ought to make fixing any remaining bugs straightforward. What will take the

Re: More bugs in Custom themes

2005-07-05 Thread Luc Teirlinck
but I think we already discussed the proper conflict resolution method. What I suggested was that the themes are listed in an order, and later themes override earlier themes. It is a little bit more complex than that. The user can enable or disable themes, save options through Custom, s

Re: More bugs in Custom themes

2005-07-05 Thread Luc Teirlinck
Richard Stallman wrote: "A proper design" doesn't identify a specific problem I could address, The very first design decision to be made is: what do we want Custom Themes to be and how do we want them to be used. I do not even know what _kind_ of Custom Themes the current code is trying to im

Re: More bugs in Custom themes

2005-07-04 Thread Richard M. Stallman
The Themes code needs to be rewritten using a proper conflict resolution algorithm and a proper design. "A proper design" doesn't identify a specific problem I could address, but I think we already discussed the proper conflict resolution method. What I suggested was that the themes

Re: More bugs in Custom themes

2005-07-03 Thread Richard M. Stallman
There is currently no support for Custom Themes in Emacs that comes remotely close to working. I'm sure the facts you are stating are accurate, but your emotional response to the bugs is overstated. They are just bugs, and they just need to be fixed. I'm going to stand by my decision. W

Re: More bugs in Custom themes

2005-07-02 Thread Luc Teirlinck
Richard Stallman wrote: This feature is already in Emacs, it is important, and I will not stand for giving up on it. That is the wrong attitude. I repeat: I do not suggest giving up on (proper) Themes support. I suggest putting it off until after the release. Are those two equivalent?

Re: More bugs in Custom themes

2005-07-02 Thread Luc Teirlinck
Richard Stallman wrote: They ARE a new feature. This feature is already in Emacs, There is currently no support for Custom Themes in Emacs that comes remotely close to working. The three unfixed bugs I mentioned are just examples. As another example, a fourth bug is that when an option's va

Re: More bugs in Custom themes

2005-07-02 Thread David Kastrup
"Richard M. Stallman" <[EMAIL PROTECTED]> writes: > Custom themes would be a completely new complex feature, not a bug > fix: > > They ARE a new feature. This feature is already in Emacs, it is > important, and I will not stand for giving up on it. That is the > wrong attitude. > > Would

Re: More bugs in Custom themes

2005-07-02 Thread Richard M. Stallman
Custom themes would be a completely new complex feature, not a bug fix: They ARE a new feature. This feature is already in Emacs, it is important, and I will not stand for giving up on it. That is the wrong attitude. Would you please work on fixing this? Otherwise we will have to wait

Re: More bugs in Custom themes

2005-06-30 Thread Luc Teirlinck
First new bug. After requiring a theme and then setting and saving some option through Custom, all my customizations for all options for which the theme specified a value were deleted. Can you fix that? Second new bug: `custom-create-theme' can not handle variables

Re: More bugs in Custom themes

2005-06-30 Thread Richard M. Stallman
First new bug. After requiring a theme and then setting and saving some option through Custom, all my customizations for all options for which the theme specified a value were deleted. Can you fix that? Second new bug: `custom-create-theme' can not handle variables with a def

More bugs in Custom themes

2005-06-29 Thread Luc Teirlinck
As I already said in another message, things are still a _lot_ worse than I thought yesterday. The Custom themes feature in its current form is actually completely unusable and it seems impossible to make it usable without a substantial effort in correcting porting errors and finishing off the por