Re: foreground menu bug

2005-06-28 Thread Mathias Dahl
"Richard M. Stallman" <[EMAIL PROTECTED]> writes: > Also, what does a disabled menu item tell the user? He might not > understand that it is because font lock is enabled. He might wonder if > he is doing something wrong seeing that menu item disabled. > > This makes no sense. Menu ite

Re: foreground menu bug

2005-06-27 Thread Richard M. Stallman
Also, what does a disabled menu item tell the user? He might not understand that it is because font lock is enabled. He might wonder if he is doing something wrong seeing that menu item disabled. This makes no sense. Menu items are disabled when they are not applicable; users know tha

Re: foreground menu bug

2005-06-27 Thread Werner LEMBERG
> > After doing that, the colour `red' is added to the last submenu so > > that it can be accessed as > > > > Edit->Text Properties->Foreground Color->red > > > > Doing this on another region, it is *not* coloured. > > > > IMHO, this is a bug. > > Could you test this patch? The CVS from today i

Re: foreground menu bug

2005-06-27 Thread Mathias Dahl
"Richard M. Stallman" <[EMAIL PROTECTED]> writes: > Or, it could just warn the user that the highlighting will not be > visible since font lock is enabled? > > It would be possible, but why be so complicated? > This change seems to do the right job. Assuming the user notices that we disab

Re: foreground menu bug

2005-06-26 Thread Richard M. Stallman
You asked if someone would like to work on this and I said I would. In the meantime I've written a functional equivalent patch. It's a bit a waste of resources to do double work. Sorry. I came across the message again, and didn't remember we had discussed it, so it seemed easiest sim

Re: foreground menu bug

2005-06-26 Thread Lute Kamstra
"Richard M. Stallman" <[EMAIL PROTECTED]> writes: > Or, it could just warn the user that the highlighting will not be > visible since font lock is enabled? > > It would be possible, but why be so complicated? > This change seems to do the right job. You asked if someone would like to work

Re: foreground menu bug

2005-06-25 Thread Richard M. Stallman
Or, it could just warn the user that the highlighting will not be visible since font lock is enabled? It would be possible, but why be so complicated? This change seems to do the right job. *** facemenu.el 08 Mar 2005 22:24:04 -0500 1.77 --- facemenu.el 25 Jun 2005 18:19:29 -0400

Re: foreground menu bug

2005-06-21 Thread Mathias Dahl
Richard Stallman <[EMAIL PROTECTED]> writes: > I tested this the other day too and was confuzzled (confused + > puzzled). After a while I realized that it had to do woth > font-lock-mode overriding my coloring. > > Perhaps those menu items should be disabled when Font Lock is enabled.

Re: foreground menu bug

2005-06-20 Thread Lute Kamstra
Richard Stallman <[EMAIL PROTECTED]> writes: > I tested this the other day too and was confuzzled (confused + > puzzled). After a while I realized that it had to do woth > font-lock-mode overriding my coloring. > > Perhaps those menu items should be disabled when Font Lock is enabled.

Re: foreground menu bug

2005-06-20 Thread Lute Kamstra
Hi Werner, > [emacs CVS 2005-06-12 with GTK] > > If I mark a text region and select the menu entry > > Edit->Text Properties->Foreground Color->Other... > > I can select a colour (say, red) and everything is fine. > > After doing that, the colour `red' is added to the last submenu so > that it c

Re: foreground menu bug

2005-06-17 Thread Lute Kamstra
Richard Stallman <[EMAIL PROTECTED]> writes: > I think you and Werner are talking about different things. You talk > about Font Lock mode overriding the text properties you set manually. > Werner's problem happens even when Font Lock mode is off. The "red" > menu entry (that is c

Re: foreground menu bug

2005-06-16 Thread Richard Stallman
I think you and Werner are talking about different things. You talk about Font Lock mode overriding the text properties you set manually. Werner's problem happens even when Font Lock mode is off. The "red" menu entry (that is created automatically when you set the foreground t

Re: foreground menu bug

2005-06-16 Thread Lute Kamstra
Mathias Dahl <[EMAIL PROTECTED]> writes: > Werner LEMBERG <[EMAIL PROTECTED]> writes: > >> [emacs CVS 2005-06-12 with GTK] >> >> If I mark a text region and select the menu entry >> >> Edit->Text Properties->Foreground Color->Other... >> >> I can select a colour (say, red) and everything is fine

Re: foreground menu bug

2005-06-15 Thread Richard Stallman
I tested this the other day too and was confuzzled (confused + puzzled). After a while I realized that it had to do woth font-lock-mode overriding my coloring. Perhaps those menu items should be disabled when Font Lock is enabled. That way, people will see they're not supposed to work.

Re: foreground menu bug

2005-06-15 Thread Mathias Dahl
Werner LEMBERG <[EMAIL PROTECTED]> writes: > [emacs CVS 2005-06-12 with GTK] > > If I mark a text region and select the menu entry > > Edit->Text Properties->Foreground Color->Other... > > I can select a colour (say, red) and everything is fine. > > After doing that, the colour `red' is added to

foreground menu bug

2005-06-15 Thread Werner LEMBERG
[emacs CVS 2005-06-12 with GTK] If I mark a text region and select the menu entry Edit->Text Properties->Foreground Color->Other... I can select a colour (say, red) and everything is fine. After doing that, the colour `red' is added to the last submenu so that it can be accessed as Edit->