Re: mouse-face on mode-line and header-line

2005-05-30 Thread Masatake YAMATO
> * Masatake YAMATO (2005-05-13) writes: > > > I've implemented mouse-face on mode-line. > > On my system (GTK-enabled CVS Emacs from yesterday on X11) the active > regions flicker quite a lot when the mouse pointer is moved over them. > Also CPU usage increases considerably while doing this. Th

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Masatake YAMATO
> Nick Roberts wrote: > > > But shouldn't the cursor change to a hand cursor rather than an arrow > > cursor when hoovering over a mouse-face? > >Following the change, if you have just line-number-mode on ,then the arrow >pointer still displays over this area (I think this may be

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Luc Teirlinck
Nick Roberts wrote: > But shouldn't the cursor change to a hand cursor rather than an arrow > cursor when hoovering over a mouse-face? Following the change, if you have just line-number-mode on ,then the arrow pointer still displays over this area (I think this may be an existing

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Nick Roberts
> But shouldn't the cursor change to a hand cursor rather than an arrow > cursor when hoovering over a mouse-face? Following the change, if you have just line-number-mode on ,then the arrow pointer still displays over this area (I think this may be an existing bug not an introduced one). Nick

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Ralf Angeli
* Masatake YAMATO (2005-05-13) writes: > I've implemented mouse-face on mode-line. On my system (GTK-enabled CVS Emacs from yesterday on X11) the active regions flicker quite a lot when the mouse pointer is moved over them. Also CPU usage increases considerably while doing this. -- Ralf

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Masatake YAMATO
> > I've implemented mouse-face on mode-line. > > > > This looks nice! > > But shouldn't the cursor change to a hand cursor rather than an arrow > cursor when hoovering over a mouse-face? Thank you for suggestion. I've installed a new patch. Please, try again. Masatake YAMATO ___

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Masatake YAMATO
> Using completely different color for the same action is too confusing. > If there is not enough contrast between adjacent highlighted and > active/inactive mode line areas, then the color of mode-line-highlight > could be adjusted to a darker color. For example, replacing "DarkSeaGreen2" > used

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Juri Linkov
>Good improvement, but there is no reason to have two different faces >with different colors for the same purpose - highlighting text areas >under the mouse pointer. > > I believe there is, because the mode line has a different background face. > I believe that the regular highlight fac

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Masatake YAMATO
From: Luc Teirlinck <[EMAIL PROTECTED]> > Juri Linkov wrote: > >Good improvement, but there is no reason to have two different faces >with different colors for the same purpose - highlighting text areas >under the mouse pointer. > > I believe there is, because the mode line has a diff

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Luc Teirlinck
Juri Linkov wrote: Good improvement, but there is no reason to have two different faces with different colors for the same purpose - highlighting text areas under the mouse pointer. I believe there is, because the mode line has a different background face. I believe that the regular high

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Juri Linkov
> *** Mouse-face on mode-line(and header-line) is now supported. > `mode-line-highlight' is the standard face indicating mouse sensitive > elements on mode-line(and header-line) like `highlight' face on text > areas. Good improvement, but there is no reason to have tw

Re: mouse-face on mode-line and header-line

2005-05-27 Thread Kim F. Storm
Masatake YAMATO <[EMAIL PROTECTED]> writes: > I've implemented mouse-face on mode-line. > This looks nice! But shouldn't the cursor change to a hand cursor rather than an arrow cursor when hoovering over a mouse-face? -- Kim F. Storm <[EMAIL PROTECTED]> http://www.cua.dk ___

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Luc Teirlinck
I plan to install the changes in the message I am replying to if nobody objects and no new bug reports surface about the new mouse-face on mode line functionality. (All that the proposed changes do is add the mode-line-highlight mouse-face to additional places for which it makes sense.) I will wa

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Luc Teirlinck
Masatake YAMATO wrote: I've just installed new patch. Please, try. Seems to work fine. Sincerely, Luc. ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Masatake YAMATO
> Matsatake Yamato wrote: > >> so I would say don't uninstall it just >> yet. It fails at one point of the code. It might be a simple fix. >I'll try. However, as far as my short inspection, it is not simple. >Anyway, I'll take more time tonight. > > Just in case it would be of any

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Luc Teirlinck
Matsatake Yamato wrote: > so I would say don't uninstall it just > yet. It fails at one point of the code. It might be a simple fix. I'll try. However, as far as my short inspection, it is not simple. Anyway, I'll take more time tonight. Just in case it would be of any help, here is a

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Richard Stallman
Should I add next sentences to etc/NEWS? *** Mouse-face on mode-line(and header-line) is now supported. `mode-line-highlight' is the standard face indicating mouse sensitive elements on mode-line(and header-line) like `highlight' face on text areas. Yes. And

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Richard Stallman
Well, perhaps installing non-bug-fixing changes to xdisp.c in the middle of a code freeze was not the greatest idea. This was not a new feature. It was a change to make a general feature work in a case where it simply failed to operate. ___ Em

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Juanma Barranquero
> This was not a new feature. It was a change to make a general feature > work in a case where it simply failed to operate. My apologies. -- /L/e/k/t/u ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman

Re: mouse-face on mode-line and header-line

2005-05-24 Thread Juanma Barranquero
> I'll uninstall my change tonight. Not because of me, certainly. I'm not blaming your or anything. I'm just adding my voice to those that ask for a stricter policy, as a matter of fact. I've been out of Emacs development almost a year, and the then soon-to-be-released 21.4 (now 22.1) is still soo

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Nick Roberts
Masatake YAMATO writes: > > > With ruler-mode turned on, I find it very easy to crash Emacs: > > > > Well, perhaps installing non-bug-fixing changes to xdisp.c in the > > middle of a code freeze was not the greatest idea. > > > > Yes, I know Masatake asked for objections and there were none

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Masatake YAMATO
> Masatake YAMATO writes: > > > > With ruler-mode turned on, I find it very easy to crash Emacs: > > > > > > Well, perhaps installing non-bug-fixing changes to xdisp.c in the > > > middle of a code freeze was not the greatest idea. > > > > > > Yes, I know Masatake asked for objections and t

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Masatake YAMATO
> On 5/23/05, Nick Roberts <[EMAIL PROTECTED]> wrote: > > > With ruler-mode turned on, I find it very easy to crash Emacs: > > Well, perhaps installing non-bug-fixing changes to xdisp.c in the > middle of a code freeze was not the greatest idea. > > Yes, I know Masatake asked for objections and

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Juanma Barranquero
On 5/23/05, Nick Roberts <[EMAIL PROTECTED]> wrote: > With ruler-mode turned on, I find it very easy to crash Emacs: Well, perhaps installing non-bug-fixing changes to xdisp.c in the middle of a code freeze was not the greatest idea. Yes, I know Masatake asked for objections and there were none.

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Luc Teirlinck
For consistency should not also the following changes be made? I can install them, if desired. They are the result of grepping for make-mode-line-mouse-map in the Lisp directory. I guess that changes to gnus should also work for older Emacs versions and for XEmacs. But before your changes were

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Nick Roberts
> I've implemented mouse-face on mode-line. With ruler-mode turned on, I find it very easy to crash Emacs: M-x ruler-mode list-buffers (C-x C-b) Click mouse-1 back and forth between windows Program received signal SIGSEGV, Segmentation fault. 0x08092911 in note_mode_line_or_margin_highlight (w

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Masatake YAMATO
> Masatake Yamoto wrote: > >I've installed my patch. > > The ChangeLog contains: > > * faces.el (mode-line-highlight): New face. > > But apparently no such change to faces.el was made when the other > listed changes were installed. > > Sincerely, Thank you. I've just installed the fac

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Luc Teirlinck
Masatake Yamoto wrote: I've installed my patch. The ChangeLog contains: * faces.el (mode-line-highlight): New face. But apparently no such change to faces.el was made when the other listed changes were installed. Sincerely, Luc. ___ Emacs-

Re: mouse-face on mode-line and header-line

2005-05-23 Thread Masatake YAMATO
down-mouse-1] 'mouse-major-mode-menu) This may be useful for users who hide the menu-bar in their .emacs. Should I add next sentences to etc/NEWS? *** Mouse-face on mode-line(and header-line) is now supported. `mode-line-highlight' is the standard face indicating mouse sensitive

Re: mouse-face on mode-line and header-line

2005-05-21 Thread Masatake YAMATO
> I've implemented mouse-face on mode-line. No objection to install this patch? ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: mouse-face on mode-line and header-line

2005-05-13 Thread Stefan Monnier
> I've implemented mouse-face on mode-line. Yay! Stefan ___ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel

mouse-face on mode-line and header-line

2005-05-13 Thread Masatake YAMATO
I've implemented mouse-face on mode-line. help-echo is useful. However, it just tells the position where you can do something. It doesn't tell the area where you can do something. mouse-face helps you to notify the area. As examples, I've put mouse-face on the standard mode line format defind in