Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Well, after re-reading my letter - it obviously probably comes off as being very strong and ambitious. I am pretty cool-headed about everything. I am aware of that I need to gradual do ideally clean and 100% compatible changes, I looked at the code - and the changes needed are at the pretty simple

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Anton Latukha
Ok.I would tend to it.This hardcode goes through several org.el functions. The main custom priority (priority retrieval) function should be already working and accepted in the whole Org system. But that hardcode expectation of (* 1000 ..) should be moved-out of the main priority functions and be su

Re: [O] managing repetitive code in export & tangling

2019-10-08 Thread Sebastian Miele
Matt Price writes: > In my lectures i often have simple examples that build progressively > over several slides. In order to use klipse properly, but also for > clarity, I gneerally repeat variable declarations from slide to slide, > so for instance: > > ** Making Lists (Arrays) > > +#NAME: js-ar

Re: [O] Bug: COMMENT and noweb-ref

2019-10-08 Thread Sebastian Miele
I wrote: > I wrote: > >> org-babel-tangle on >> >> * A >> >> #+BEGIN_SRC elisp :tangle yes :noweb yes >> ;; A >> <> >> #+END_SRC >> >> * COMMENT B >> >> #+BEGIN_SRC elisp :noweb-ref B >> ;; B >> #+END_SRC >> >> * COMMENT C >> >> #+BEGIN_SRC elisp :tangle yes

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-08 Thread Jens Lechtenboerger
On 2019-10-08, at 11:31, Nicolas Goaziou wrote: > Jens Lechtenboerger writes: > >> The attached patch adds a new variable org-html-wrap-src-lines to >> control whether code tags should be added or not. > > Thank you. > > However, the patch is not right. Exporters do not use defcustoms > directly.

[O] managing repetitive code in export & tangling

2019-10-08 Thread Matt Price
In my lectures i often have simple examples that build progressively over several slides. In order to use klipse properly, but also for clarity, I gneerally repeat variable declarations from slide to slide, so for instance: ** Making Lists (Arrays) +#NAME: js-array-historians #+BEGIN_SRC js let h

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-10-08 Thread Anton Latukha
Indeed, I now also understand so.Let's drop this one. 08.10.2019, 13:59, "Nicolas Goaziou" :Hello,Anton Latukha writes:  Additionally state that this is a holder of a function name, so the simple user did not get confused.Your patch doesn't sound right. The value could be a lamb

[O] [PATCH] Document "help:" Org link type in manual

2019-10-08 Thread Robert Irelan
Patch attached -- Robert Irelan rire...@gmail.com From 31867e399f00093647c1b0583b7682b407be5b55 Mon Sep 17 00:00:00 2001 From: Robert Irelan Date: Tue, 8 Oct 2019 03:17:49 -0700 Subject: [PATCH] Document "help:" Org link type --- doc/org-manual.org | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [O] [PATCH] ox-html: add option to restore old src block behaviour?

2019-10-08 Thread Nicolas Goaziou
Hello, Jens Lechtenboerger writes: > The attached patch adds a new variable org-html-wrap-src-lines to > control whether code tags should be added or not. Thank you. However, the patch is not right. Exporters do not use defcustoms directly. Instead, you register them within :options-alist in t

Re: [O] [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Another two small patches. Please merge the two patches and factor out the (- org-lowest-priority ...) while you're at it. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org.el: fx org-get-priority-function funcall (give arg - headline)

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > * org.el (org-get-priority): Fix to allow the use of custom priority > getters. > Provide the headline as argument to the custom priority getter > function. Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] Bug: org-publish-resolve-external-link doesn't respect org-export-with-broken-links for fuzzy links

2019-10-08 Thread Nicolas Goaziou
Hello, Robert Irelan writes: > Patch to fix attached Applied. Thank you. Regards, -- Nicolas Goaziou

Re: [O] [PATCH] org: org-get-priority-function: Clearly state that this is a holder for a name of the function

2019-10-08 Thread Nicolas Goaziou
Hello, Anton Latukha writes: > Additionally state that this is a holder of a function name, so the > simple user did not get confused. Your patch doesn't sound right. The value could be a lambda function, or a symbol with a function value. Besides, "function name" is confusing. It could mean, e