Re: Bug: Incorrect done TODO keywords highlighting in column view

2020-10-18 Thread Martin Kampas
Hi Kyle, You are right, I completely forgot about columns view under the "regular" buffers. Updated patch below. BR, Martin >From 288c157ea95e00de4b508e0fd257b51857e097b9 Mon Sep 17 00:00:00 2001 From: Martin Kampas Date: Mon, 19 Oct 2020 07:22:57 +0200 Subject: [PATCH] org-colview: Fix done

Re: Bug: org-cycle stops working on Org files with empty lines at end of buffer [9.4 (9.4-elpaplus @ /home/brentg/.emacs.d/elpa/org-plus-contrib-20200914/)]

2020-10-18 Thread stardiviner
A simple temporary solution to this bug is remove hook function from ~org-cycle-hook~: #+begin_src emacs-lisp (remove-hook 'org-cycle-hook #'org-cycle-show-empty-lines) #+end_src stardiviner writes: > Bastien writes: > >> Hi, >> >> stardiviner writes: >> >>> I also did a bisect debug.

Re: [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct Type)

2020-10-18 Thread Kevin Foley
Kyle Meyer writes: > I imagine tastes vary on whether using cl-defstruct here is an overkill. > (To my eyes, it is.) More importantly, though, I think changing it now > means we'd also need a compatibility layer, which doesn't seem worth the > trouble. I tried implementing it and realized: 1.

[PATCH] [WIP] org-agenda.el: Make org-entries-lessp more efficient

2020-10-18 Thread Adam Spiers
[This is only lightly tested and therefore probably not quite ready for merging yet; however I'm submitting now to get feedback.] org-entries-lessp was not as efficient a multi-criteria comparator as it could have been, since it evaluated all criteria and then combined them via (eval (cons 'or

[PATCH] org-agenda.el: Fix 'Maker' typo

2020-10-18 Thread Adam Spiers
TINYCHANGE Signed-off-by: Adam Spiers --- lisp/org-agenda.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index a1b20649d..88bb3f90d 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4127,7 +4127,7 @@ (defvar

Re: Bug: Incorrect done TODO keywords highlighting in column view

2020-10-18 Thread Kyle Meyer
Martin Kampas writes: > Hi, > > In columns view, all TODO keywords except those with face set explicitly with > org-todo- > keyword-faces are red. Done keywords should be green. [...] > Subject: [PATCH] org-colview: Fix done TODO keywords highlighting > > * lisp/org-colview.el

Re: Org Refile RFLOC and Struct Type

2020-10-18 Thread Kyle Meyer
Kevin Foley writes: > I was recently working with `org-refile` and wanted to use a custom > target. There is the `rfloc` argument which is documented as: > >> RFLOC can be a refile location obtained in a different way. > > There's no documentation as to how `rfloc` should be structured. To >

Re: Disabling automatic links for timestamps and tags

2020-10-18 Thread Kyle Meyer
Peter Bienstman writes: > Thanks! Is there a way to achieve this while still keeping the syntax > highlighting intact? I'm not aware of a built-in option to do that. If you want to come up with a custom solution, the code to study is org-set-font-lock-defaults, which in turn calls

Re: best practices query: non-emacs packages based on tangled source

2020-10-18 Thread Tom Gillespie
Hi Greg, Great question. This came out a bit longer than I anticipated since I wrote up a couple of relevant workflows. Sync between org source blocks and tangled code is something that I think needs improvement. I have covered the difference in semantics between tangled code and babel evaluated