[PATCH v2] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output

2022-08-13 Thread Joseph Turner
Document the new functionality of ob-plantuml to insert ASCII diagrams directly in the buffer. --- .../babel/languages/ob-doc-plantuml.org | 57 +++ 1 file changed, 46 insertions(+), 11 deletions(-) diff --git a/org-contrib/babel/languages/ob-doc-plantuml.org

Re: [PATCH] org-contrib/babel/languages/ob-doc-plantuml.org: ASCII output

2022-08-13 Thread Joseph Turner
You're right! Thank you for catching my mistake. I'll send another patch. Joseph Ihor Radchenko writes: > Joseph Turner writes: > >> Document the new functionality of ob-plantuml to insert ASCII diagrams >> directly in the buffer. > > Thanks! > >> -=PlantUML= requires a working >>

Re: Bug: Table does not align if there is non-breaking space [9.4.3 (9.4.3-elpa @ /home/data1/protected/.emacs.d/elpa/org-20201216/)]

2022-08-13 Thread Ihor Radchenko
Jean Louis writes: >> Could you please detail what you mean by does not align well? >> Your table looks fine on my side. > > See attached frameshot. > > I can see that it aligns well in `emacs -Q'. However no matter what > theme I tried in running Emacs I could not get it to align. Do you > know

Re: Bug: Table does not align if there is non-breaking space [9.4.3 (9.4.3-elpa @ /home/data1/protected/.emacs.d/elpa/org-20201216/)]

2022-08-13 Thread Jean Louis
* Ihor Radchenko [2022-08-13 14:47]: > Jean Louis writes: > > > > > > > | Date | Description | Expense | > > |+-+-| > > | 2022-08-12 | Buying

[DONE] Re: [BUG] Latest org-fold-core API (overlays compatible code) caused error in package "consult-org-heading"

2022-08-13 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> Here I attached the backtrace after I toggle-debug-on-error: >> >> Debugger entered--Lisp error: (wrong-type-argument listp #> to 77 in org-fold-core-test.org>) >> car(#) >> (let ((--mpom (car region))) (save-excursion (if

Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-13 Thread Ihor Radchenko
Max Nikulin writes: >> I do not think that it is a good idea. We currently promise to use the >> first function in the list to generate the IDs. Other functions are >> mostly a fallback to catch the existing attach dirs created in the past >> using different ID scheme. > > My idea is to add an

Re: how to beamer export overlay figure?

2022-08-13 Thread Ihor Radchenko
"Fraga, Eric" writes: >> Otherwise, looks good. > > Can you apply it please? Applied onto main via 3303a54d7 upcasing the beginning of comment and adding "." at the end. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3303a54d74805cdd2b6eda37285f259949f7ba2e -- Ihor

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-13 Thread Ihor Radchenko
Max Nikulin writes: >>> It looks like (string-prefix-p "file:" bare) but without the complex >>> regexp. I see, such code was used before. By the way, why it is "bare", >>> not e.g. "target"? >> >> match-end is used later in the code. Thus, string-match is justified. > > The matched string is

Re: [BUG] Latest org-fold-core API (overlays compatible code) caused error in package "consult-org-heading"

2022-08-13 Thread Ihor Radchenko
"Christopher M. Miles" writes: > Here I attached the backtrace after I toggle-debug-on-error: > > Debugger entered--Lisp error: (wrong-type-argument listp # 77 in org-fold-core-test.org>) > car(#) > (let ((--mpom (car region))) (save-excursion (if (markerp --mpom) (progn > (set-buffer

Re: [BUG] Latest org-fold-core API (overlays compatible code) caused error in package "consult-org-heading"

2022-08-13 Thread Christopher M. Miles
"Christopher M. Miles" writes: > [[PGP Signed Part:Undecided]] > > I have this option settings: > > #+begin_src emacs-lisp > (setq org-element-use-cache nil) > (setq org-fold-core-style 'overlays) > (setq org-fold-catch-invisible-edits nil) > > (use-package consult > :ensure t > :bind

[BUG] Latest org-fold-core API (overlays compatible code) caused error in package "consult-org-heading"

2022-08-13 Thread Christopher M. Miles
I have this option settings: #+begin_src emacs-lisp (setq org-element-use-cache nil) (setq org-fold-core-style 'overlays) (setq org-fold-catch-invisible-edits nil) (use-package consult :ensure t :bind (([remap org-goto] . consult-org-heading)) ; [C-c C-j] :config (require 'consult-org))

Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-13 Thread Max Nikulin
On 13/08/2022 12:29, Ihor Radchenko wrote: Max Nikulin writes: I believe that interaction between `org-attach-dir-from-id' and members of `org-attach-id-to-path-function-list' could be improved. If a too short ID is passed to `org-attach-id-uuid-folder-format',

Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-08-13 Thread Max Nikulin
On 12/08/2022 23:08, Janek F wrote: I use org-roam which creates links between org-files using the ID, and I would like to be able to manually add such links to common pages even if autocompletion doesn't work smoothly. Unfortunately I have not tried org-roam yet. My suggestion is to add

Re: Maintaining oc-csl

2022-08-13 Thread Bruce D'Arcus
Yes please; and thanks for volunteering! On Sat, Aug 13, 2022, 8:47 AM András Simonyi wrote: > Dear All, > > I'd like to volunteer to maintain oc-csl.el, which currently doesn't > have an official maintainer as far as I can tell. As the author and > maintainer of citeproc-el and the author of

Re: Toggling select-enable-clipboard & select-enable-primary prevents org-copy-visible to work

2022-08-13 Thread Ihor Radchenko
Ihor Radchenko writes: > This is not normal, and I can reproduce the issue. > However, it does not look like Org is doing anything wrong. We call > kill-new with the correct value containing only visible part of the > buffer. > > I suggest you to file a bug report to Emacs itself using M-x

Re: [RFC PATCH] oc-csl: Add support for title, locators and bibentry styles

2022-08-13 Thread Bruce D'Arcus
On Sat, Aug 13, 2022 at 8:30 AM András Simonyi wrote: > > Dear All, > > On Tue, 9 Aug 2022 at 17:38, Rudolf Adamkovič wrote: > > > THANK YOU for working on this! I have tried the "locators" style, and > > it works great. At last, we can write in the APA style with no hacks! > > thanks for your

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-13 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> After applying this patch, seems deep level has improved. > > Thanks for testing! > Applied onto main via 6ad65f333. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ad65f3332937dee81b1a7dc56a6dca7bd4865ae > Thanks

[DONE] Re: [SOMEDAY] Re: [BUG] inline src_lang code is not fontified on headline

2022-08-13 Thread Christopher M. Miles
Confirmed problem fixed. "Christopher M. Miles" writes: > [[PGP Signed Part:Undecided]] > > Ihor Radchenko writes: > >> "Christopher M. Miles" writes: >> >>> The src_lang code fontification is normal in content, but not correctly >>> fontified on headline. >>> >>> There is a screenshot in

Re: org-cite-insert + fido-mode

2022-08-13 Thread Tyler Grinn
András Simonyi writes: That works! Thank you. > Could you try Alt-j? > > best wishes, > András > > On Sat, 13 Aug 2022 at 03:22, Tyler Grinn wrote: >> >> "Bruce D'Arcus" writes: >> >> > You need to use whatever keybinding exits. >> >> I've tried every key in the mode map. >>

Re: Maintaining oc-csl

2022-08-13 Thread Christian Moe
András Simonyi writes: > Dear All, > > I'd like to volunteer to maintain oc-csl.el, which currently doesn't > have an official maintainer as far as I can tell. As the author and > maintainer of citeproc-el and the author of oc-csl's precursor, > citeproc-org, I think I'm reasonably well

Maintaining oc-csl

2022-08-13 Thread András Simonyi
Dear All, I'd like to volunteer to maintain oc-csl.el, which currently doesn't have an official maintainer as far as I can tell. As the author and maintainer of citeproc-el and the author of oc-csl's precursor, citeproc-org, I think I'm reasonably well positioned to handle issues and make

Re: [RFC PATCH] oc-csl: Add support for title, locators and bibentry styles

2022-08-13 Thread András Simonyi
Dear All, On Tue, 9 Aug 2022 at 17:38, Rudolf Adamkovič wrote: > THANK YOU for working on this! I have tried the "locators" style, and > it works great. At last, we can write in the APA style with no hacks! thanks for your kind words, I'm glad that you find the additions useful. > P.S. Not

Re: Bug: Table does not align if there is non-breaking space [9.4.3 (9.4.3-elpa @ /home/data1/protected/.emacs.d/elpa/org-20201216/)]

2022-08-13 Thread Ihor Radchenko
Jean Louis writes: > > > | Date | Description | Expense | > |+-+-| > | 2022-08-12 | Buying store, PRN 2230001079059 | -5 | > | 2022-08-12 |

Re: how to beamer export overlay figure?

2022-08-13 Thread Fraga, Eric
Hi Ihor, On Saturday, 13 Aug 2022 at 17:16, Ihor Radchenko wrote: > I guess the message is only for testing here. Indeed. I did send a subsequent patch without the message line. Attached here again just in case. > Otherwise, looks good. Can you apply it please? Thank you, eric -- : Eric

Re: [Patch] Show org file title in org-clock clocktable

2022-08-13 Thread Ihor Radchenko
Duy Nguyen writes: > Not sure how you normally go about updates to submitted patches. For this > time, I just updated the patch by amending the commit of the previous patch > I sent. Please let me know another approach is preferable going forward. This is ok. Ideally, you can also assign

Re: [Patch] Show org file title in org-clock clocktable

2022-08-13 Thread Duy Nguyen
> > Please use the built-in org-collect-keywords instead. > Thanks for the pointer, I changed the function in the attached patch. This is a user-facing change and should be documented in etc/ORG-NEWS file. Updated both the etc/ORG-NEWS and the doc/org-manual.org files. Not sure how you

Bug: Table does not align if there is non-breaking space [9.4.3 (9.4.3-elpa @ /home/data1/protected/.emacs.d/elpa/org-20201216/)]

2022-08-13 Thread Jean Louis
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: how to beamer export overlay figure?

2022-08-13 Thread Ihor Radchenko
"Fraga, Eric" writes: > + ((string-match "includegraphics\\([[{]?\\)" latex-link) > + ;; check for overlay specification and insert if present > + (message "matched") I guess the message is only for testing here. Otherwise, looks good. -- Ihor

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-13 Thread Ihor Radchenko
"Christopher M. Miles" writes: > After applying this patch, seems deep level has improved. Thanks for testing! Applied onto main via 6ad65f333. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6ad65f3332937dee81b1a7dc56a6dca7bd4865ae > I attched the profiler report in

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-13 Thread Max Nikulin
On 13/08/2022 13:42, Ihor Radchenko wrote: Max Nikulin writes: + (bare (and (string-match org-link-bracket-re l) +(match-string 1 l +(when bare + (if (and org-babel-tangle-use-relative-file-links + (string-match

Re: [Patch] Show org file title in org-clock clocktable

2022-08-13 Thread Ihor Radchenko
Duy Nguyen writes: > Please find attached a patch to allow users to show the org file titles > (i.e. the value of #+title) instead of the file name in the org-clock > clocktable. Thanks for the contribution! > I created this patch as I am using a combination of org-roam and org-agenda > to

Re: [PERFORMANCE] Why some org code is so deep invoked?

2022-08-13 Thread Ihor Radchenko
"Christopher M. Miles" writes: > 668 28%- > org-agenda-prepare-buffers > ... > 523 22% - > org--tag-add-to-alist I have a suspicion where the bottleneck is. Can you try the attached patch?

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-13 Thread Ihor Radchenko
Max Nikulin writes: >> + (bare (and (string-match org-link-bracket-re l) >> +(match-string 1 l >> +(when bare >> + (if (and org-babel-tangle-use-relative-file-links >> + (string-match org-link-types-re bare) >> +

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-13 Thread Ihor Radchenko
Hraban Luyat writes: >>> @Ihor: I have rebased the patch and attached it. Applied onto main via 8a781d35d. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8a781d35dc68f20fa2a5546c98ba3d9b77ee3cda Thanks again for your contribution! -- Ihor Radchenko, Org mode contributor,

Re: Suspected bug: '#+STARTUP: indent' messes up inlinetasks' tag alignment

2022-08-13 Thread Ihor Radchenko
alain.coch...@unistra.fr writes: > Then, to observe the problem, I can for example compare > > (1) visiting the file pb.org containing: > >#+STARTUP: noindent >* headline 1 :htag: >*** inelinetask :itag: >*** END >