[PATCH v4.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-16 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > (seq-take (seq-uniq (append bound-tags fulltable)) org-fast-tag-selection-maximum-tags)) >>> >>> This will behave awkwardly with tag groups. You may

ob-clojure: results quoted nil

2023-05-16 Thread rab
Hello! I am trying to follow examples on a book and I noticed a minor bug that is literally "bugging" me. :-D The quoted NIL is not showing on the Result block. Org mode version 9.6.1 (9.6.1-??-fe92a3ced @ /Users/rafiks/.emacs.d/.local/straight/build-28.2/org/) #+begin_src clojure :results

Re: org code and error catching

2023-05-16 Thread Michael Heerdegen
Ihor Radchenko writes: > As for condition-case-unless-debug, may you create a patch? > But please do not replace everything blindly - I know for sure that at > least some `condition-case' clauses are there on purpose. I nearly never had a closer look at the org-mode code (other than blindly).

Re: Minimal list of packages for `guix shell` for documentation compilation?

2023-05-16 Thread Kyle Meyer
Kyle Meyer writes: > Ah, sorry, I should have tested that with --pure. Indeed you'll need to > pull in other packages if they're not already on your system. [...] Here's the minimum set of packages I needed with --pure: $ guix shell --pure \ coreutils diffutils emacs-minimal glibc git

Re: org code and error catching

2023-05-16 Thread Ihor Radchenko
Michael Heerdegen writes: > Ihor Radchenko writes: > >> What are those? >> I do not have anything failing on my side. > > See the attached file. I had been using an up-to-date Emacs master build. Ah. Different locale (LANG). It is

Re: org code and error catching

2023-05-16 Thread Michael Heerdegen
Ihor Radchenko writes: > What are those? > I do not have anything failing on my side. See the attached file. I had been using an up-to-date Emacs master build. Michael. <>

Re: [PATCH] lisp/org/ol.el: org-link-make-description-function is always applied

2023-05-16 Thread Ihor Radchenko
Feraidoon Mehri writes: > The change is very small, so I think taking a look at the diff is more > informative than I trying to explain it; the old code did not use > `org-link-make-description-function` when some other alternatives were > available, but my changes make it always use >

Re: [ANN] lisp/ob-tangle-sync.el

2023-05-16 Thread Ihor Radchenko
Mehmet Tekman writes: >> I feel confused when reading the modified code. >> > > Okay, I guess comments are not my strong suit. I will try to remove any > unnecessary comments and use better variable names. No, comments were useful. They revealed that our understanding of the expected behaviour

Re: [PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-16 Thread Ihor Radchenko
"Christopher M. Miles" writes: >>> (seq-take (seq-uniq (append bound-tags >>> fulltable)) >>> org-fast-tag-selection-maximum-tags)) >> >> This will behave awkwardly with tag groups. You may better use >> `org--tag-add-to-alist'.

[PATCH] lisp/org/ol.el: org-link-make-description-function is always applied

2023-05-16 Thread Feraidoon Mehri
I have signed the copyright assignment before. The change is very small, so I think taking a look at the diff is more informative than I trying to explain it; the old code did not use `org-link-make-description-function` when some other alternatives were available, but my changes make it always

Re: Minimal list of packages for `guix shell` for documentation compilation?

2023-05-16 Thread Kyle Meyer
Kyle Meyer writes: > Running this from the top of the Org repo works for me (Guix > 270db2a56bc5): > > $ guix shell emacs -- make doc Ah, sorry, I should have tested that with --pure. Indeed you'll need to pull in other packages if they're not already on your system. Adding '-D emacs' to

Re: Minimal list of packages for `guix shell` for documentation compilation?

2023-05-16 Thread Kyle Meyer
Yuval Langer writes: > I would like to run `make doc` under `guix shell` to test my > documentation patches. > > Does anyone know the minimal list of packages and proper `guix shell` > incantation for that? Running this from the top of the Org repo works for me (Guix 270db2a56bc5): $ guix

Minimal list of packages for `guix shell` for documentation compilation?

2023-05-16 Thread Yuval Langer
I would like to run `make doc` under `guix shell` to test my documentation patches. Does anyone know the minimal list of packages and proper `guix shell` incantation for that? Thank you, Yuval Langer.

[PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-16 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> Updated version which fix the `message` error in upper code: > > Thanks! > >> #+begin_src emacs-lisp >> (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) >> (if (length< fulltable >>

Re: [ANN] lisp/ob-tangle-sync.el

2023-05-16 Thread Mehmet Tekman
Hello, thanks for the last review and sorry for the lapse in communication. May is proving to be a very strange month. Ihor Radchenko writes: > Mehmet Tekman writes: >> >> I've modified the `merge' function within `org-babel-merge-params' so >> that the main logic now accumulates a list of

Re: [PATCH v2] Re: [PATCH] add a function to only refresh inline images under current headline instead of global buffer

2023-05-16 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> I'd prefer something more closely resembling `org-latex-preview' >>> approach with prefix arguments: >>> ... >>> `org-toggle-inline-images' should also be changed. >> >> Here is the source code of `org-toggle-inline-images'. I

[PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-16 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> Updated version which fix the `message` error in upper code: > > Thanks! > >> #+begin_src emacs-lisp >> (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) >> (if (length< fulltable >>

Re: org-element tutorial?

2023-05-16 Thread Ihor Radchenko
bvchg...@mail.com writes: > Does anyone know of a good tutorial on using org-element? I'm finding > the documentation hard to grok. We have https://orgmode.org/worg/dev/org-element-api.html > Alternatively, given a doc like > > * TODO No > ** Uninteresting >- item 1 >- item 2 > > * NEXT

Re: org code and error catching

2023-05-16 Thread Ihor Radchenko
Michael Heerdegen writes: > Hmm - mine gave a different result: I cloned the org-mode archive from > https://git.savannah.gnu.org/git/emacs/org-mode.git, called "make" and > ran the tests as described in the "testing/README". That gave 6 failing > tests. What are those? I do not have anything

Re: [PATCH v3.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-16 Thread Ihor Radchenko
"Christopher M. Miles" writes: > Updated version which fix the `message` error in upper code: Thanks! > #+begin_src emacs-lisp > (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) > (if (length< fulltable > org-fast-tag-selection-maximum-tags) Because of

Re: [PATCH v2] Re: [PATCH] add a function to only refresh inline images under current headline instead of global buffer

2023-05-16 Thread Ihor Radchenko
"Christopher M. Miles" writes: >> I'd prefer something more closely resembling `org-latex-preview' >> approach with prefix arguments: >> ... >> `org-toggle-inline-images' should also be changed. > > Here is the source code of `org-toggle-inline-images'. I implement this > by reference