Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-04 Thread Jack Kamm
Ihor Radchenko writes: > WORG documentation is not accurate here. > > If the block has :file parameter _or_ :file-exp parameter and #+name, > the results of evaluation are inserted into a file. Otherwise, results > of evaluation are interpreted as file name--*undocumented*. > > That said, your

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-04 Thread Jack Kamm
Liu Hui writes: > Hi, > > This patch adds graphics output support for ob-python via matplotlib. > Specifically, it allows to use header argument `:results file > graphics' as follows: > > #+begin_src python :file "test.png" :results graphics file > import matplotlib.pyplot as plt >

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-04 Thread Jack Kamm
Ihor Radchenko writes: > Liu Hui writes: > >> This patch adds graphics output support for ob-python via matplotlib. >> Specifically, it allows to use header argument `:results file >> graphics' as follows: >> >> #+begin_src python :file "test.png" :results graphics file >> import

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-04 Thread Samuel Wales
On 7/4/23, Ihor Radchenko wrote: > Samuel Wales writes: > >>> -UUU:**--F1 *Org Links*Top L1 (Fundamental) >> >> this buffer contains nothing useful and shortens the above buffer. > > This is fine. I assume that you can simply hide it away using > `display-buffer-alist'. i have

[BUG] org-element loading fails with "regexp" argument not "stringp"

2023-07-04 Thread Justin
Using emacs 26.1 (in case it matters).  Loading is failing at: (defconst org-element--current-element-re   (rx    (or     (group-n 1 (regexp org-element--latex-begin-environment-nogroup)) rx is a macro, and so org-element* is not being evaluated.  It's complaining that the argument to regexp

[PATCH] Use compat org-time-convert-to-list for emacs <27.1

2023-07-04 Thread Justin
---  lisp/org-macs.el | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org-macs.el b/lisp/org-macs.el index 2eed0028e..d6879e8cf 100644 --- a/lisp/org-macs.el +++ b/lisp/org-macs.el @@ -803,7 +803,7 @@ When NEXT is non-nil, check the next line instead."    "Return string

[PATCH] org-src: flatten-tree is Emacs 27.1; require compat

2023-07-04 Thread Justin
Also available at fake PR https://github.com/vallon/org-mode/pull/1 git fetch https://github.com/vallon/org-mode compat-for-flatten-tree ---  lisp/org-src.el | 1 +  1 file changed, 1 insertion(+) diff --git a/lisp/org-src.el b/lisp/org-src.el index 317682844..b8db7c128 100644 ---

[PATCH v3] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands

2023-07-04 Thread Evgenii Klimov
Ihor Radchenko writes: > Evgenii Klimov writes: [...] > Few comments. > > First, please add Changelog entry for etc/ORG-NEWS. Done. >> +(defvar org-metaleft-final-hook nil >> + "Hook for functions attaching themselves to `M-left'. >> +See `org-ctrl-c-ctrl-c-hook' for more information.") > >

Re: [BUG] error wholenump in org agenda on reschedule [9.6.1 (9.6.1-??-fe92a3c @ /data/data/com.termux/files/home/.config/emacs/.local/straight/build-28.3/org/)]

2023-07-04 Thread Ihor Radchenko
[ Adding Org ML back to CC ] Nick Römer writes: > Debugger entered--Lisp error: (wrong-type-argument wholenump -2)  > move-to-column(-2 t)  org-move-to-column(-2 t)  > org-agenda-show-new-time ... Thanks! Does the attached patch solve the problem? >From cd7c52972ea93029278f462fb0240e49aaba4fa2

Re: [BUG] error wholenump in org agenda on reschedule [9.6.1 (9.6.1-??-fe92a3c @ /data/data/com.termux/files/home/.config/emacs/.local/straight/build-28.3/org/)]

2023-07-04 Thread Ihor Radchenko
Nick Römer via "General discussions about Org-mode." writes: > In org agenda view, on terminal Emacs version running in termux on my > Samsung galaxy A10, I get an Error "wholenump -3" when selecting one or > more TODOs with the "m" key and subsequently trying to reschedule using > the key

Re: [PATCH v2] lisp/org.el: Add final hooks to S-/M-/S-M-cursor commands

2023-07-04 Thread Ihor Radchenko
Evgenii Klimov writes: > Maybe I got it wrong, but I tried to follow the docstring for > `org-metaleft'. And I don't see here the use of the return value either: > > #+begin_example > (defun org-metaleft ( _arg) > "... > This function runs the hook `org-metaleft-hook' as a first step,

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-04 Thread Ihor Radchenko
[ CCing ob-python maintainer. ] Liu Hui writes: >> May you elaborate? >> >> #+begin_src python :results file >> implies that the result of execution is file _contents_. > > It is consistent with current behavior, e.g. `:results file' is used > to produce graphics file >

Re: [PATCH v2] Keep the link if the command was cancelled

2023-07-04 Thread Ihor Radchenko
Evgenii Klimov writes: > I added `link-original' variable to keep it intact until we want to > remove the link from `org-stored-links'. Thanks! Applied, onto main, with amendments. I have added TINYCHANGE cookie to the commit message and provided a bit more details in the commit summary.

Re: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)]

2023-07-04 Thread Ihor Radchenko
Sébastien Miquel writes: > From 9d31a71bc0ab7cfd466ecad60037d00c62bdd9f6 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?S=C3=A9bastien=20Miquel?= > Date: Tue, 27 Jun 2023 09:23:01 +0200 > Subject: [PATCH] org-src.el: Use native value of `indent-tabs-mode' for > indentation Thanks! This looks good

Re: org-insert-link completion by description (Re: what is the purpose of "This link has already been stored"?)

2023-07-04 Thread Ihor Radchenko
Samuel Wales writes: >> -UUU:**--F1 *Org Links*Top L1 (Fundamental) > > this buffer contains nothing useful and shortens the above buffer. This is fine. I assume that you can simply hide it away using `display-buffer-alist'. > --- >> http: https: >>