Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil

2023-07-08 Thread Ihor Radchenko
Ilya Chernyshov writes: >> Interpreting timestamps with :time-range nil and >> :day-end/:year-end/:month-end non-nil as timerange is a breaking change. >> Let's avoid it. > > Timestamp objects (ranges) with :range-type nil are now interpreted as > dateranges, as it was before. I still have quest

Re: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)]

2023-07-08 Thread Ihor Radchenko
Sébastien Miquel writes: > Ihor Radchenko writes: >> Sebastien, it looks like one of the tests is failing on the older Emacs: >> https://builds.sr.ht/~bzg/job/1020247 > > Does this specify anywhere what version of emacs it is using ? Yup. In the full log https://builds.sr.ht/query/log/1020247/bu

Re: [BUG] org-list-struct-apply-struct overrides src block indentation (was: [BUG] Source block indentation does not work properly for yaml-mode [9.6.6 ( @ /home/user/.emacs.d/elpa/org-9.6.6/)])

2023-07-08 Thread Ihor Radchenko
Sébastien Miquel writes: > Ihor Radchenko writes: >> The cause is the following line in `org-list-struct-apply-struct' >> [[file:~/Git/org-mode/lisp/org-list.el::indent-line-to (+ >> (org-current-text-indentation) delta)))]] >> >> It calls `indent-line-to' that replaces spaces with tabs accordi

Re: [PATCH v2] Fix Emacs-26 compatibility (was: Re: [BUG] org-element loading fails with "regexp" argument not "stringp")

2023-07-08 Thread Ihor Radchenko
Max Nikulin writes: > On 06/07/2023 16:54, Ihor Radchenko wrote: >> You are removing `org-protocol-flatten' function, which is a breaking >> change. We should leave an obsolete alias. > > I have added an alias for this function hardly known to anybody else. It was easy enough, so why not. There

Re: [PATCH v2] org-faq.org: Inline comments

2023-07-08 Thread Ihor Radchenko
Max Nikulin writes: >> The proposed FAQ entry is overwhelming. It would work fine as a blog, >> but not as a quick answer to a question. I recommend leaving only the >> @@comment:...@@ part > > See a shortened variant. Thanks! >> - it is what we use ourselves in WORG sources. > > I have not fou

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-08 Thread Jack Kamm
Ihor Radchenko writes: > Your patch appear to only add more confusion, IMHO. > > I feel that the description about :results file is confusing from the > very beginning: Well, I guess ":results file" has confusing behavior. So it's difficult to write accurate, comprehensive, non-confusing documen

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-08 Thread Jack Kamm
Liu Hui writes: > I think your proposal about ":results graphics" is more flexible and > complies the documentation. Since the patch has no real problem and > the feature is useful indeed, I hope it can be merged instead of mine > after the problem of documentation is resolved. Thanks for your g

Re: inconsistency links and code line labels

2023-07-08 Thread Dan Drake
I should have mentioned that I'm not exporting any of this. I only use org by itself; I never export things to other formats. So the link behavior that I need is for making and following links inside org/emacs; noweb and other things aren't important. The (ahem) link to the org-coderef-label-forma