Re: [Bug] org-insert-link removes on one link from 2 added by org-store-link

2023-07-12 Thread Samuel Wales
link has already been stored is a bug in my case in that i can't just go to a header, grab it [whether rabbed bfere or not] and then paste it. i surprise easily when the wrong link gets pasted. [also the id links with no desc and the prefix links do not help me find the link i want to insert if

[PATCH] ob-tangle.el: Blocks overwrite each other when grouping before tangling

2023-07-12 Thread Evgenii Klimov
And here's the patch to fix it. >From 2695d48f265a4100a9fc25c4dd278ab2b4b89ba5 Mon Sep 17 00:00:00 2001 From: Evgenii Klimov Date: Wed, 12 Jul 2023 19:24:48 +0100 Subject: [PATCH] ob-tangle.el: Avoid relative file names when grouping blocks to tangle * lisp/ob-tangle.el

[BUG] ob-tangle.el: Blocks overwrite each other when grouping before tangling

2023-07-12 Thread Evgenii Klimov
Hi, I noticed that during grouping of blocks to tangle some of them can overwrite each other if they have the same target file, but in different format (relative vs absolute). Consider this example (part of example.org file in the attachment): * 1st explicit :tangle yes #+begin_src

Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-07-12 Thread Jonathan Gregory
Hi Ihor On 12 Jul 2023, Ihor Radchenko wrote: [...] I have recently seen https://masto.ai/@rfc1149/110674961710491363 that revealed a problem with example from https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html#org29a742f Instead of lilypond fragments, full pages

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Jack Kamm
Liu Hui writes: > OK, I have added a test to the patch. While your test works on its own, it seems to break subsequent tests (the next test hangs). My guess is that it has something to do with the fact that most of the Python session tests share the same session, and ob-python is getting

Re: [PATCH] org.el: Remove undefined dynamic variable `org-log-states' from example

2023-07-12 Thread Evgenii Klimov
Ihor Radchenko writes: > It looks like 5 working days have passed since your email to FSF. If so, > please follow up once and wait another 5 working days. I've got papers from FSF, signed it and sent it back. It was 6 working days ago. 5 days that you mention is for the first response from

[PATCH] testing: Delete duplicate tests

2023-07-12 Thread Ilya Chernyshov
Hello. In my last patch, I found a duplicate test, so I decided to find all of the duplicate tests inside testing/lisp/ folder via this function: (defun count-duplicate-tests ( directory) (let (files) (dolist (file (directory-files (or directory default-directory) t (rx ".el" string-end)

Re: [BUG] Incorrect indentation when there are invisible/diplay properties on the line [9.6.7 ( @ /home/huzf/.cache/emacs_configs/default/elpa.28/org-9.6.7/)]

2023-07-12 Thread Ihor Radchenko
Hammer Hu writes: > ** heading > >text 1 > > #+begin_quote > block > #+end_quote > >text 2 > --- > > It makes it easy to copy code snippets from org file without emacs. Check out org-src-preserve-indentation. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org

Re: [BUG] Incorrect indentation when there are invisible/diplay properties on the line [9.6.7 ( @ /home/huzf/.cache/emacs_configs/default/elpa.28/org-9.6.7/)]

2023-07-12 Thread Hammer Hu
When indent-region, instead of getting: --- ** heading text 1 #+begin_quote block #+end_quote text 2 --- we allow the it to be: --- ** heading text 1 #+begin_quote block #+end_quote text 2 --- It makes it easy to copy code snippets from org file without emacs. I put

Re: [PATCH] org.el: Remove undefined dynamic variable `org-log-states' from example

2023-07-12 Thread Ihor Radchenko
Evgenii Klimov writes: > PS: I didn't add TINYCHANGE since I have reached the contribution > limit but FSF didn't respond yet. It looks like 5 working days have passed since your email to FSF. If so, please follow up once and wait another 5 working days. -- Ihor Radchenko // yantar92, Org

[BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-07-12 Thread Ihor Radchenko
"Dr. Arne Babenhauserheide" writes: > I typically use it directly, but if the maintenance burden is > manageable, I could offer maintenance here, too (once I have the papers > in place). I have recently seen https://masto.ai/@rfc1149/110674961710491363 that revealed a problem with example from

Re: [Bug] org-insert-link removes on one link from 2 added by org-store-link

2023-07-12 Thread Max Nikulin
On 02/07/2023 14:49, Ihor Radchenko wrote: Max Nikulin writes: M-x org-store-link adds 2 entries: - [[*title][title]] - [[#a-heading][title]] however `org-insert-link' (C-c C-l) removes from the stored link only one of them. As a result the number of unused stored links increases during an

Re: [PATCH] Keep the link if the command was cancelled

2023-07-12 Thread Max Nikulin
On 03/07/2023 22:28, Ihor Radchenko wrote: If necessary, removing stored links without inserting can be made as an effect of negative prefix argument in `org-insert-link' or in `org-insert-all-links'. I do not think it would be a noticeable improvement. It increases code complexity, but

Re: [PATCH] ob-python: Fix async evaluation

2023-07-12 Thread Liu Hui
Jack Kamm 于2023年7月12日周三 12:51写道: > The patch looks good, but it would be nice to include a unit test as > well -- could you update the patch to include one, Liu Hui? OK, I have added a test to the patch. From 56fd5e05bc7dc82fb825416100e75663a520 Mon Sep 17 00:00:00 2001 From: Liu Hui Date:

Re: [BUG] Incorrect indentation when there are invisible/diplay properties on the line [9.6.7 ( @ /home/huzf/.cache/emacs_configs/default/elpa.28/org-9.6.7/)]

2023-07-12 Thread Ihor Radchenko
Hammer Hu writes: > Thanks for your accommodations. Is it possible to introduce a feature to align > all blocks to the begining to the lines when indenting? I thing it helps when > copying contents from a org file without emacs installed. May you elaborate? -- Ihor Radchenko // yantar92, Org

Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-12 Thread Ihor Radchenko
Jack Kamm writes: > Ihor Radchenko writes: > >> ":results file" imply that results of the code block are written to a file >> (the file is specified using header args). >> >> ":results file link" imply that results of the code block are interpreted >> as file link. The fact that presence of

Re: [PATCH] org-element-timestamp-interpreter: Return daterange anyway, if DATERANGE is non-nil

2023-07-12 Thread Ihor Radchenko
Ilya Chernyshov writes: > From 823e7f39d33977854605485fcae814af0a3fdefe Mon Sep 17 00:00:00 2001 > From: Ilya Chernyshov > Date: Sat, 18 Feb 2023 14:55:39 +0700 > Subject: [PATCH] lisp/org-element.el: Add new timestamp property :range-type Thanks! Applied, onto main, with slight amendments. I