Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

2024-06-20 Thread Al Haji-Ali
On 20/06/2024, Ihor Radchenko wrote: > Al Haji-Ali writes: > Makes sense. > Applied, onto bugfix. > Fixed. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix=a4ff518 Thanks! > > Maybe. I am slightly cautious about adding it without public discussion >

Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

2024-06-20 Thread Al Haji-Ali
On 19/06/2024, Ihor Radchenko wrote: > Al Haji-Ali writes: > >> On 18/06/2024, Ihor Radchenko wrote: >>> Hmm. Thanks, but the patch does not apply on my side. >>> May you instead create a patch as a separate file, add the commit >>> message, and at

Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

2024-06-18 Thread Al Haji-Ali
Al >From 0efafc38b404bace9ff87e38349a6c64fc7be903 Mon Sep 17 00:00:00 2001 From: Al Haji-Ali Date: Tue, 18 Jun 2024 19:27:56 +0100 Subject: [PATCH] Use file-truename for files of refile targets. Ensures that comparing filenames works even when symlinks are used. --- lisp/org-refile.el | 4 ++-- 1 file changed, 2 insertions(+),

Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

2024-06-17 Thread Al Haji-Ali
On 17/06/2024, Ihor Radchenko wrote: > Makes sense. > May you prepare a patch with the proposed change? > See https://orgmode.org/worg/org-contribute.html#first-patch It's not really a long patch, just involves calling `file-truename` instead of `expand-file-name` in a couple of places. diff

[BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

2024-06-17 Thread Al Haji-Ali
I have `org-refile-use-outline-path` set to t, expecting that when refiling, the filename should not appear in the list. However, because I am opening an org file using a symblink and I have `find-file-visit-truename` set to `t`, the test `(not (equal filename (nth 1 x)))` in

extended background on org-block-end-line

2022-11-08 Thread Al Haji-Ali
I'll admit this "bug" is not critical, but it is visually annoying (at least to me). When hiding an org entry, source blocks with extended backgrounds remain visible. To re-produce: 0. Run `emacs -Q` 1. Create a buffer with this content and ensure `org-mode` is on

Re: [BUG] org-agenda-prepare-buffers does not save restrictions

2022-07-10 Thread Al Haji-Ali
t;From fcaff9b583c46c0d147aaf4c7e3647f689d54894 Mon Sep 17 00:00:00 2001 From: Al Haji-Ali Date: Sun, 10 Jul 2022 09:46:26 +0100 Subject: [PATCH] lisp/org.el: Save restrictions in all agenda file buffers. * lisp/org.el (org-agenda-prepare-buffers): Call `org-with-wide-buffer' for every

Re: [BUG] org-agenda-prepare-buffers does not save restrictions

2022-07-08 Thread Al Haji-Ali
On 08/07/2022, Ihor Radchenko wrote: > Could you please create a proper patch See attached. I made a further change to use `with-current-buffer` instead of `set-buffer+save-excursion`. Best regards, -- Al >From 398fee0c235c53399cd8cc481f9e732f64ae88cb Mon Sep 17 00:00:00 2001 From: Al Ha

[BUG] org-agenda-prepare-buffers does not save restrictions

2022-07-07 Thread Al Haji-Ali
I am not sure if this has been reported before, of if the behaviour is intended. But to reproduce this "bug": - Open an org file from the agenda. - Restrict to some headline - Execute the following command: (with-temp-buffer (org-agenda-prepare-buffers (org-agenda-files t))) - The

Bug: Infinite loop in org-agenda-dim-blocked-tasks

2020-08-21 Thread Al Haji-Ali
On the latest release (9.3.7), I am running into an infinite loop when clocking in a blocked task if `org-enforce-todo-dependencies` is set to `t`. The (manual) call stack is: org-agenda-clock-in org-agenda.el:9760 org-agenda-change-all-lines org-agenda.el:9391 org-agenda-finalize