Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-08-31 Thread Gavin Downard
Ihor Radchenko writes: > It has been over one month since the last message in this thread. > Gavin, may I know if you are still interested to work on the patch? Apologies for the lack of communication. I do plan on working on this patch in the near future.

Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-26 Thread Gavin Downard
Max Nikulin writes: > The regexp for parsing formulas does not allow named references after @. > I have no idea if other code should be modified as well. I consider it > as more important than detection of duplicated definitions. Yeah, besides changing the regexp, the main thing that will need to

Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-25 Thread Gavin Downard
Max Nikulin writes: > I have tried the patch. The formula for the named column "$three=" does > not work. > > | ! | one | two | three | four | > |---+-+-+---+--| > | # | 1 | 2 | |3 | > > #+tblfm: @>$5=$one+$two::@>$three=$one+$two Yeah, I guess my current patch only

Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-23 Thread Gavin Downard
Ihor Radchenko writes: > Do we have any tests covering this part of the code? Not that I know of. I can add a test case for this specific instance, but I'm not sure if I should add more comprehensive tests in this patch. What do you think? > In Emacs 26, we will need (require 'subr-x), but other

Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-22 Thread Gavin Downard
Max Nikulin writes: > On 19/07/2023 09:36, Gavin Downard wrote: >> +++ b/lisp/org-table.el >> @@ -2253,8 +2253,7 @@ LOCATION is a buffer position, consider the formulas >> there." >> ((not (match-end 2)) m) >>

Re: [PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-21 Thread Gavin Downard
Max Nikulin writes: > When I tried table formulas a couple of years ago I was surprised that it is > not > possible to use column names to specify target cells. At first glance it > should > be a great feature. Have you searched the mailing list archive whether it was > requested earlier? Ther

[PATCH] lisp/org-table.el: Allow named columns on lhs

2023-07-18 Thread Gavin Downard
pretty confusing. >From c6ebbf02e0cb89839606338e8bbc4032810ea398 Mon Sep 17 00:00:00 2001 From: Gavin Downard Date: Sat, 1 Jul 2023 13:26:46 -0700 Subject: [PATCH] lisp/org-table.el: Allow named columns on lhs * lisp/org-table.el (org-table-recalculate): Add support for named columns on the lhs