Re: org-element: headline's :title is sometimes string, sometimes list

2023-08-23 Thread Hraban Luyat
Thank you Ihor. On 8/23/23 5:49 AM, Ihor Radchenko wrote: > Hraban Luyat writes: > >> I expect: "string" everywhere. >> >> I get: >> >> Headline title from map is of type: cons >> Headline title from context is of type: string >

org-element: headline's :title is sometimes string, sometimes list

2023-08-22 Thread Hraban Luyat
Hi all. I'll let the code speak: (with-temp-buffer (org-mode) (insert "* Hello") (cl-flet ((say-type (prefix hl) (message "Headline title from %s is of type: %s" prefix (type-of

Re: [PATCH 1/2] test-ox-html: checkboxes: ascii, html & unicode

2023-08-10 Thread Hraban Luyat
Thank you for the sensible amendments On 8/10/23 5:36 AM, Ihor Radchenko wrote: > Hraban Luyat writes: > >> I've added some minor unit tests for checkboxes in ox-html. I was >> playing around with something I thought was a bug, which turned out to >> be my project c

Re: [PATCH 2/2] test-ox-html: postamble format

2023-08-09 Thread Hraban Luyat
XD forgot the attachment On 8/9/23 4:50 PM, Hraban Luyat wrote: > Another test for ox-html, this time for postamble options handling. > It's quite tricky, apparently. > > > Hraban >From c054e5d3e9a0813da7c8e269fdfc9ae98c322aa9 Mon Sep 17 00:00:00 2001 From: Hraban Luyat Date:

[PATCH 2/2] test-ox-html: postamble format

2023-08-09 Thread Hraban Luyat
Another test for ox-html, this time for postamble options handling. It's quite tricky, apparently. Hraban

[PATCH 1/2] test-ox-html: checkboxes: ascii, html & unicode

2023-08-09 Thread Hraban Luyat
f9a343cc23bd5e99346797dd5e1cf4d1c661a605 Mon Sep 17 00:00:00 2001 From: Hraban Luyat Date: Wed, 9 Aug 2023 14:09:18 -0400 Subject: [PATCH 1/2] test-ox-html: checkboxes: ascii, html & unicode --- testing/lisp/test-ox-html.el | 69 1 file changed, 69 insertions(+) diff -

ox-html: no tests, besides mathjax?

2023-08-08 Thread Hraban Luyat
Hi all, I was looking for ox-html unit tests and found testing/lisp/test-ox-html.el, which contains only mathjax tests. I didn't find any other (unit) tests for HTML. Is that correct? Thought I'd sanity check this, before I go on a wild goose chase. Thanks all Hraban

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-11 Thread Hraban Luyat
On 8/11/22 12:26 AM, Ihor Radchenko wrote: > Hraban Luyat writes: > >>> Is there any problem with the following? >>> >>> (alist-get :tangle params) >> >> This bit of code was moved, I didn't write it. The original code uses a >> va

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-08-10 Thread Hraban Luyat
bare)) to this? (and bare x y) If that's what you meant, I think it would evaluate differently if bare = truthy and x = falsy, right? Form 1 evaluates to `bare', form 2 evaluates to x (i.e. NIL). Or did I misunderstand the suggestion? @Ihor: I have rebased the patch and attached it.From 7

Re: [PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-07-30 Thread Hraban Luyat
On 7/30/22 12:56 AM, Ihor Radchenko wrote: > Hraban Luyat writes: > >> This is my first org-mode patch, all comments welcome :). I signed a >> copyright assignment to the FSF 2021-07-12. > > Thanks for the contribution! > > Bastien, could you please check the FSF rec

[PATCH] ob-tangle.el: fix ‘:comments noweb’ double linking

2022-07-28 Thread Hraban Luyat
* lisp/ob-tangle.el: Refactor the double implementation to a single helper function. This avoids the double link wrapping. * testing/lisp/test-ob-tangle.el: Add unit tests. Babel tangle allows inserting comments at the tangled site which link back to the source in the org file. This linking was