Awesome!
Thanks again for all the help. It's been a crash course in org internals
and the contribution process.
Well prepared for next time to go much smoother.
Cheers,
-ryan
On Tue, Jun 14, 2022 at 6:47 AM Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > I put together
d problems with an introduced assumption that the buffer-file-name
would be non-nil (causing several tests to fail) as well as being generally
overzealous in detecting file result paths as attachment links.
On Mon, Jun 13, 2022 at 10:55 PM Ryan Scott
wrote:
> Strange. I'll figure out
Strange. I'll figure out a better setup for running the tests and get to
the bottom of that.
Thanks for the help.
On Tue, Jun 14, 2022, 00:10 Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > Ah sorry about that. I'm on a windows laptop and didn't have make, so was
&g
t need to do any guessing on their behalf. Implicit ID creation
should likely live elsewhere anyway.
On Sat, Jun 11, 2022 at 5:49 AM Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > Had no experience with the :DIR: property or writing unit tests for Org,
> > but I think I&#
sts that I should modify.
Thanks,
-ryan
On Fri, Jun 10, 2022 at 9:31 PM Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > I believe I have addressed your feedback, Ihor.
> > Attached is the latest version of the patch.
> >
> >- Merged latest master
> >-
uotes)" to help make the NEWS entry clearer
- Changed the attach directory detection to use a string prefix check
Let me know what you think.
On Thu, Apr 21, 2022 at 11:19 PM Ryan Scott
wrote:
> Great. Just making sure that this particular approach to this feature or
> type o
Great. Just making sure that this particular approach to this feature or
type of feature wasn't fundamentally flawed given the established behavior
of org.
Thanks.
On Thu, Apr 21, 2022 at 11:02 PM Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > With all of the layers and assu
poor ego. :)
With all of the layers and assumptions/behaviors inherent in the way src
block parameters are handled, do you feel like this is an approach that can
work, or should it be abandoned?
Thanks for looking into this.
On Thu, Apr 21, 2022, 05:46 Ihor Radchenko wrote:
> Ryan Scott
ed documentation and completed the copyright assignment to the FSF.
On Mon, Oct 4, 2021 at 6:05 PM Ryan Scott wrote:
> I've been working through a few different approaches. What's shaping up is
> something more general, having a special value for directory parameters
> (i.e. 'a
). Maybe we can introduce something like
>> :results-dir header arg to set the output directory? It's value can be a
>> directory path or symbol 'attach.
>>
>> `:results file :results-dir 'attach` will be equivalent of `:results file
>> attach` in the patch p
eels. That would
carve out space for other options in handling attachments.
On Sat, Oct 2, 2021, 01:31 Ihor Radchenko wrote:
> Ryan Scott writes:
>
> >(default-directory
> > -(or (and dir (file-name-as-directory dir)) default-directory))
> > +
* org-attach.el (org-attach-dir): Added autoload header to simplify
dependencies necessary to support this feature (called in
`org-babel-execute-src-block').
On Sun, Sep 5, 2021 at 6:56 AM Ryan Scott wrote:
> Yeah your second example is what I'm thinking. It makes this all a fairly
&
Yeah your second example is what I'm thinking. It makes this all a fairly
concise extension of that existing mechanism and does away with the file
move after execution.
On Sun, Sep 5, 2021, 06:21 Ihor Radchenko wrote:
> Ryan Scott writes:
>
> > It might make sense to fix
> directory (aka input files directory). Maybe we can introduce something
> like :results-dir header arg to set the output directory? It's value can
> be a directory path or symbol 'attach.
>
> `:results file :results-dir 'attach` will be equivalent of
> `:results file attach` in the patch proposed by Ryan Scott.
>
> WDYT?
>
> Best,
> Ihor
>
letely right to me.
On Wed, Sep 1, 2021 at 1:01 PM Ryan Scott wrote:
> I hadn't thought about input directories much as my usage of
> graphviz/gnuplots is through [essentially] DSLs that I made for them, so
> the blocks are actually elisp.
> Perhaps a convenient way of setting the
oding style doesn't include a hard line limit, so it just
wasn't on my mind.
I'll get my patch updated and submitted shortly. Thanks for the help!
On Wed, Sep 1, 2021 at 7:44 AM Ihor Radchenko wrote:
> Ryan Scott writes:
>
> The patch looks fine for me except a typo:
&
p to 72 characters (if you use
> Magit, this should happen automatically FYI). Other than that it looks
> good to me.
>
> All the best,
> *Timothy*
>
> * From*: Ryan Scott <%22ryan+scott%22+%3cr...@vicarious-living.com%3E>
> * Subject*: New source block results option for
An additional option for use with ":results file" that moves the returned
path to the node attachment directory (as returned by org-attach-dir),
creating it if necessary.
First time submitting a patch. Any feedback is appreciated.
-ryan
0001-ob-core-Added-option-for-attaching-file-from-babel-s.
18 matches
Mail list logo
