Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

YE writes: >> Ihor Radchenko writes: >> See the attached tentative patch. > > Thanks, LGTM so far. Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=51937d4b1 Fixed. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

> Bruno Barbier writes: > The change seems to come from this commit: > >commit d7a55bbd537314d2776b082bd92a1a08b3edc84e >Date: Wed Sep 28 12:07:14 2022 +0800 >org-latex-export-to-latex: Do not suppress major modes in babel > Thank you for finding the culprit. > Ihor Radchenko writ

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Ihor Radchenko writes: > AFAIU, `require-final-newline' is t by default, except binary data. > Also, Org export is not designed to generate binary output. > So, it should be OK to ensure the final newline manually, in > `org-export-to-file' - to minimize possible breakage. See the attached tenta

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Bruno Barbier writes: > The change seems to come from this commit: > >commit d7a55bbd537314d2776b082bd92a1a08b3edc84e >Date: Wed Sep 28 12:07:14 2022 +0800 >org-latex-export-to-latex: Do not suppress major modes in babel > > It replaces 'write-file' with 'write-region', but, accordi

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Hi Ye, Ihor, Max, The change seems to come from this commit: commit d7a55bbd537314d2776b082bd92a1a08b3edc84e Date: Wed Sep 28 12:07:14 2022 +0800 org-latex-export-to-latex: Do not suppress major modes in babel It replaces 'write-file' with 'write-region', but, according to the docum

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Max Nikulin writes: >>> Ihor, it changed between Org-9.5 and 9.6. >> >> Are you sure? I tried Org 9.5 and there is no newline. > > Org mode version 9.5.5 (release_9.5.5 @ /usr/share/emacs/28.2/lisp/org/) > > and the same for uncompiled release_9.5.5 from git > > a test file containing just "test

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

On 09/10/2023 18:46, Ihor Radchenko wrote: Max Nikulin writes: On 09/10/2023 18:29, Ihor Radchenko wrote: Not ending is also not uncommon though. And causes no harm (no bug reports during all the >10 years when ox-html is a thing). Ihor, it changed between Org-9.5 and 9.6. Are you sure? I

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Max Nikulin writes: > On 09/10/2023 18:29, Ihor Radchenko wrote: >> Not ending is also not uncommon though. And causes no harm (no bug >> reports during all the >10 years when ox-html is a thing). > > Ihor, it changed between Org-9.5 and 9.6. Are you sure? I tried Org 9.5 and there is no newlin

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

On 09/10/2023 18:29, Ihor Radchenko wrote: Not ending is also not uncommon though. And causes no harm (no bug reports during all the >10 years when ox-html is a thing). Ihor, it changed between Org-9.5 and 9.6.

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

YE writes: >> May you please explain why missing newline is a problem? > > It's not necessarily a problem, since HTML parser implementations are > permissive. Still, a couple of arguments for adding it by default: > > 1. diff tools output "\ No newline at end of file" message when a > newline is

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

> >> Exporting HTML file from Org-mode, f.i. with `org-html-export-to-html', >> I expect to get a newline after the closing tag, but it's not >> added. I believe this used to work with previous versions of Org-mode. >> Am I missing something? > > `org-html-template' never ever had a newline at the

Re: [BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

YE writes: > Exporting HTML file from Org-mode, f.i. with `org-html-export-to-html', > I expect to get a newline after the closing tag, but it's not > added. I believe this used to work with previous versions of Org-mode. > Am I missing something? `org-html-template' never ever had a newline at

[BUG] No newline at end of exported HTML file [9.6.6 (release_9.6.6 @ /Applications/MacPorts/Emacs.app/Contents/Resources/lisp/org/)]

Exporting HTML file from Org-mode, f.i. with `org-html-export-to-html', I expect to get a newline after the closing tag, but it's not added. I believe this used to work with previous versions of Org-mode. Am I missing something? Thanks. Emacs : GNU Emacs 29.1 (build 2, aarch64-apple-darwin22.