Re: [BUG] Prompt appears in async shell results

2024-03-29 Thread Ihor Radchenko
Matt writes: > On Wed, 27 Mar 2024 11:59:06 +0100 Ihor Radchenko wrote --- > > > Over a week have passed. No objections have been raised. > > Feel free to apply the patches. > > Done. See: >

Re: [BUG] Prompt appears in async shell results

2024-03-29 Thread Matt
On Wed, 27 Mar 2024 11:59:06 +0100 Ihor Radchenko wrote --- > Over a week have passed. No objections have been raised. > Feel free to apply the patches. Done. See: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=e9c288dfaccc2960e5b6889e6aabea700ad4e05a and

Re: [BUG] Prompt appears in async shell results

2024-03-27 Thread Ihor Radchenko
Matt writes: > 1. Can people please test that the changes to > =org-babel-comint-with-output= haven't broken other languages? Over a week have passed. No objections have been raised. Feel free to apply the patches. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode

Re: [BUG] Prompt appears in async shell results

2024-03-24 Thread Matt
On Sat, 23 Mar 2024 15:16:37 +0100 Ihor Radchenko wrote --- > Yup. Tests are passing on my side as well, and I had no comments. > So, we are waiting for other interested users to test. > For at least a week, so that people who check the mailing list on > weekend have a chance to

Re: [BUG] Prompt appears in async shell results

2024-03-23 Thread Ihor Radchenko
Matt writes: > I saw no comments on the patch part of my previous message and fear it may > have been missed due to my inclusion of the lengthy and separate topic, "bug? > org-babel-comint-with-output return value type". > > The patches fix the prompt appearing in async shell results and are

Re: [BUG] Prompt appears in async shell results

2024-03-23 Thread Matt
Friendly bump. I saw no comments on the patch part of my previous message and fear it may have been missed due to my inclusion of the lengthy and separate topic, "bug? org-babel-comint-with-output return value type". The patches fix the prompt appearing in async shell results and are ready to

Re: [BUG] Prompt appears in async shell results

2024-03-17 Thread Matt
On Mon, 19 Feb 2024 12:07:55 +0100 Ihor Radchenko wrote --- > Matt m...@excalamus.com> writes: > > > - Split prompt filtering and input echoing into two filters > > + this seems to imply a =-hook= or =-functions= type implementation > > Not necessarily. You may just split the

Re: [BUG] Prompt appears in async shell results

2024-02-19 Thread Ihor Radchenko
Matt writes: > - Split prompt filtering and input echoing into two filters > + this seems to imply a =-hook= or =-functions= type implementation Not necessarily. You may just split the filter into (1) prompt remover; (2) body remover. The filter does not need to interact with comint buffer

Re: [BUG] Prompt appears in async shell results

2024-02-18 Thread Matt
On Mon, 05 Feb 2024 15:00:18 +0100 Ihor Radchenko wrote --- > Yes. The right fix would be extracting the filter from > `org-babel-comint-with-output' and re-using it. This message documents my progress so that I may switch focus to Bruno's patches in "Asynchronous blocks for

Re: [BUG] Prompt appears in async shell results

2024-02-05 Thread Ihor Radchenko
Matt writes: > #+begin_src emacs-lisp > (org-babel-do-load-languages 'org-babel-load-languages '((shell . t))) > #+end_src > > #+begin_src sh :results output :session *test* :async t > cd /tmp > echo "hello world" > #+end_src > > #+RESULTS: > : org_babel_sh_prompt> hello world Confirmed. > **

[BUG] Prompt appears in async shell results

2024-02-04 Thread Matt
* [BUG] Prompt appears in async shell results ** Minimal reproducible example #+begin_src emacs-lisp (org-babel-do-load-languages 'org-babel-load-languages '((shell . t))) #+end_src #+begin_src sh :results output :session *test* :async t cd /tmp echo "hello world" #+end_src